Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-1238.md #4966

Closed
wants to merge 1 commit into from
Closed

Add EIP-1238.md #4966

wants to merge 1 commit into from

Conversation

TimDaub
Copy link
Contributor

@TimDaub TimDaub commented Apr 1, 2022

This is a "DRAFT" proposal on how #1238 could be implemented.

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 1, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-1238.md

classification
newEIPFile
  • File with name EIPS/eip-1238.md is new and new files must be reviewed
  • This PR requires review from one of [@lightclient, @axic, @SamWilsn]

@SamWilsn
Copy link
Contributor

SamWilsn commented Apr 2, 2022

Is this ready for editor review? If not, would you mind marking as a draft PR?

@TimDaub
Copy link
Contributor Author

TimDaub commented Apr 2, 2022

For me it's fine moving the proposal to the next stage, but e.g. I don't know if the OP of #1238 is OK with me DRAFTing and sending this document.

But I guess they could object or give feedback in the editor stage too, right?

If we can move it forward, let's do it.

EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
EIPS/eip-1238.md Show resolved Hide resolved
@MicahZoltu
Copy link
Contributor

I'm closing all PRs that were open on April 1st since we received a number of "joke" EIPs. If this was in fact a serious EIP that you would like to have reviewed, please resubmit.

Note: Please keep in mind that EIP editors are all volunteers and have more work than time available.

@MicahZoltu MicahZoltu closed this Apr 5, 2022
@TimDaub
Copy link
Contributor Author

TimDaub commented Apr 5, 2022

If this was in fact a serious EIP that you would like to have reviewed, please resubmit.

It's not a joke.

Note: Please keep in mind that EIP editors are all volunteers and have more work than time available.

I'm a volunteer too :)

@TimDaub TimDaub mentioned this pull request Apr 5, 2022
14 tasks
@TimDaub
Copy link
Contributor Author

TimDaub commented Apr 5, 2022

Continued in #4973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants