Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit EIP-4973 - Account-bound tokens #4973
Submit EIP-4973 - Account-bound tokens #4973
Changes from 21 commits
b8e717d
391cca9
9754700
8d7368e
6c2a00c
40522db
2e2dd82
82dc89a
503d9c5
c5dfe52
48304f8
cd26e76
c6b6c2b
594bdaa
f2bf116
73525e9
b71be06
bc16f29
9e26685
a68efbe
15527ff
22641bd
845c337
057710f
9ef6c49
04d7113
c7a6e03
1a0b1ba
21ae681
835c9f2
6754cba
4be4df0
5df30fc
1aefe9a
acdc991
50d2c65
194f910
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend removing "standard", but I think it's fine to leave in for the draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally prefer to see this exception removed. If there is a concern due to a large amount of tokens being minted in contract creation, a merkle drop or signature-based claim system should be implemented, imho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also pretty unsure how a 3rd party indexer can index a contract that can create any number of accounts on deployment or have them already assigned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no strong opinion on this and honestly, I've just copied it from the original comment in
EIP-721
.