Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4974: Fungible Non-tradable Tokens, or EXP #4974

Merged
merged 8 commits into from
May 3, 2022

Conversation

dtedesco1
Copy link
Contributor

@dtedesco1 dtedesco1 commented Apr 5, 2022

A need exists for fungible tokens that indicate reputation in a community, rather than serve as tradable assets. Lack of such assets contributes to destructive pay-to-play dynamics in today's DAOs and blockchain games. Vitalik Buterin writes "ad nauseum" (his words) about this problem. EIP-4974 seeks solutions via a token standard similar to EXP in games or Reddit Karma.

Existing proposals and discussions for non-tradable token standards (namely, EIP-4671 and EIP-1238) have been reviewed deeply. Both are optimizing for credentials or badges, which are very different use cases from EXP.

For more background information, please view the discussion on Ethereum Magicians here and initial PR.

@eth-bot
Copy link
Collaborator

eth-bot commented Apr 5, 2022

All tests passed; auto-merging...

(pass) eip-4974.md

classification
updateEIP
  • passed!

(pass) assets/eip-4974/ERC4974.sol

classification
ambiguous
  • file assets/eip-4974/ERC4974.sol is associated with EIP 4974; because there are also changes being made to EIPS/eip-4974.md all changes to corresponding assets are also allowed

(pass) assets/eip-4974/IERC4974.sol

classification
ambiguous
  • file assets/eip-4974/IERC4974.sol is associated with EIP 4974; because there are also changes being made to EIPS/eip-4974.md all changes to corresponding assets are also allowed

(pass) assets/eip-4974/IERC4974Metadata.sol

classification
ambiguous
  • file assets/eip-4974/IERC4974Metadata.sol is associated with EIP 4974; because there are also changes being made to EIPS/eip-4974.md all changes to corresponding assets are also allowed

@dtedesco1
Copy link
Contributor Author

Awaiting to be assigned an official EIP number. I will update all files accordingly once editors decide.

Copy link
Contributor

@wschwab wschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea behind this standard is valid, but the spec needs some work. I've left some comments to try and help with that. Don't get discouraged by the comments, they're just to try and get this into top shape!

EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
EIPS/eip-888.md Outdated Show resolved Hide resolved
@dtedesco1 dtedesco1 changed the title EIP Draft: Fungible Non-tradable Tokens, or EXP EIP-4974: Fungible Non-tradable Tokens, or EXP Apr 5, 2022
co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

update links

Apply initial suggestions from code review

Update EIP number and typos.

Co-authored-by: William Schwab <31592931+wschwab@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

rename, add enumerable, update language

update name conventions, ERC165 identifier

update backwards compatability
@dtedesco1
Copy link
Contributor Author

@Pandapip1 Updated with your suggested changes. Thanks again.

EIPS/eip-4974.md Outdated Show resolved Hide resolved
EIPS/eip-4974.md Outdated Show resolved Hide resolved
@Pandapip1
Copy link
Member

Folder names are case-sensitive IIRC, and that would cause the issue with the links.

@eth-bot eth-bot merged commit cd3870a into ethereum:master May 3, 2022
PowerStream3604 pushed a commit to PowerStream3604/EIPs that referenced this pull request May 19, 2022
* Apply suggestions from initial review

co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

update links

Apply initial suggestions from code review

Update EIP number and typos.

Co-authored-by: William Schwab <31592931+wschwab@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

rename, add enumerable, update language

update name conventions, ERC165 identifier

update backwards compatability

* minor wording edit

* update with participate and transfer nomenclature

* update reference links

* update reference to assets folder

* removing the assets link
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Apply suggestions from initial review

co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

update links

Apply initial suggestions from code review

Update EIP number and typos.

Co-authored-by: William Schwab <31592931+wschwab@users.noreply.github.com>
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

rename, add enumerable, update language

update name conventions, ERC165 identifier

update backwards compatability

* minor wording edit

* update with participate and transfer nomenclature

* update reference links

* update reference to assets folder

* removing the assets link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants