-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-5083: NFT Token Acceptance Standard #5083
Closed
mw2000
wants to merge
7
commits into
ethereum:master
from
mw2000:EIP-5071--Standard-interface-for-tokens-accepted-by-NFT-Collection-
+65
−0
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0bfc231
Skeleton of NFT Token Acceptance Standard
mw2000 4117d7d
Assign EIP-5083
Pandapip1 fe58a41
A few wssential changes
Pandapip1 24aee78
Add placeholder
Pandapip1 0bd7ab4
Add to requires
Pandapip1 551b0f9
Link to eip-20
Pandapip1 ff61bfa
Update eip-5083.md
Pandapip1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
--- | ||
eip: 5083 | ||
title: NFT Token Acceptance | ||
description: Retrieve the types of EIP-20 tokens that are accepted by a particular NFT collection for buying and selling in a NFT Marketplace | ||
discussions-to: <URL> | ||
author: Mihir Wadekar (@mw2000) | ||
status: Draft | ||
type: Standards Track | ||
category: ERC | ||
created: 2022-05-05 | ||
requires: 20, 165, 721, 1155 | ||
--- | ||
|
||
## Abstract | ||
|
||
This standard allows contracts, such as NFTs that support [EIP-721](./eip-721.md) and [EIP-1155](./eip-1155.md) interfaces, to specify the permitted [EIP-20](./eip-20.md) tokens that can be used in a NFT marketplace to buy and sell the NFT from this collection. This would allow NFT creators to setup a wider economy by adding more use-cases to their own, or other EIP-20 tokens. The interface would be similar to the [EIP-2981](./eip-2981.md) standard such that it will be completely voluntary for NFT marketplaces to implement this standard in their products. | ||
|
||
## Motivation | ||
Buy/Sell transactions for NFTs on marketplaces often happen in a standard currency like ETH. Certain NFT Collections may want to enable payments in specific EIP-20 tokens only, howwever specifying this on each and every NFT Marketplace is cumbersome and creates friction. Instead, this EIP proposes the creation of a standard interface to allow NFT marketplaces to easily obtain this information from the smart contract itself. | ||
|
||
By allowing for only specific tokens to trade NFTs, an atomic use-case and economy can be created for the token. | ||
|
||
A good example for this is ApeCoin and Otherside. If Otherdeeds were only tradeable in ApeCoin, it would add much more of a use-case to the token allowing the future Otherside game to run entirely on ApeCoin, along with trading. This is also similar to Roblox and trading items exclusively in Robux, and Fortnite and trading items exclusively in V-Bucks. | ||
|
||
## Specification | ||
|
||
The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL | ||
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and | ||
"OPTIONAL" in this document are to be interpreted as described in | ||
RFC 2119. | ||
|
||
**EIP-721 and EIP-1155 compliant contracts MAY implement this EIP for specifying which tokens they would want the NFTs to be transacted in.** | ||
|
||
## Rationale | ||
|
||
### Create economy for token | ||
|
||
TODO | ||
|
||
### Allow creators to determine what tokens they receive royalties in | ||
|
||
TODO | ||
|
||
## Backwards Compatibility | ||
|
||
This standard is compatible with EIP-721 and EIP-1155. | ||
|
||
## Reference Implementation | ||
|
||
|
||
### Deploying an EIP-721 and signaling support for this EIP | ||
|
||
TODO | ||
|
||
### Checking if the NFT being sold on your marketplace implemented this standard | ||
|
||
TODO | ||
|
||
## Security Considerations | ||
|
||
There are no security considerations related directly to the implementation of this standard. | ||
|
||
## Copyright | ||
|
||
Copyright and related rights waived via [CC0](../LICENSE.md). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the title and description I feel the "token acceptance" is a bit ambiguous. Can you reduce the ambiguity in the title to match the description?