Editor changes for EIP-4400 #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
… transfer Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com>
Closed
All tests passed; auto-merging...(pass) eip-4400.md
(pass) assets/eip-4400/.gitignore
(pass) assets/eip-4400/LICENSE
(pass) assets/eip-4400/README.md
(pass) assets/eip-4400/abi/ERC721Consumable.json
(pass) assets/eip-4400/abi/IERC721Consumable.json
(pass) assets/eip-4400/contracts/ERC721Consumable.sol
(pass) assets/eip-4400/contracts/ExampleToken.sol
(pass) assets/eip-4400/contracts/IERC721Consumable.sol
(pass) assets/eip-4400/hardhat.config.ts
(pass) assets/eip-4400/package.json
(pass) assets/eip-4400/test/erc721-consumable.ts
(pass) assets/eip-4400/tsconfig.json
|
Daniel-K-Ivanov
approved these changes
May 15, 2022
There was a problem hiding this comment.
LGTM @SamWilsn and thank you for stepping up and helping out! Much appreciated 🙏
MicahZoltu
reviewed
May 17, 2022
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
License for all EIP related files must be CC0.
lightclient
requested changes
May 17, 2022
auto-merge was automatically disabled
May 17, 2022 15:33
Head branch was pushed to by a user without write access
PowerStream3604
pushed a commit
to PowerStream3604/EIPs
that referenced
this pull request
May 19, 2022
* Initial commit * add(er721-consumer-impl) Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(er721-consumer-impl) Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(er721-consumer-impl): Change to consumable + clear consumer on transfer Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(inline-docs) Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(change-consumer): Fix issue on minting Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * add(tests): Add tests for the reference implementation Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * add(abi): Add ABI files Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * add(example-impl): Decouple implementation from example token Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * chore: change title of README.md Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * Apply editor feedback * fix typo * Remove package-lock.json to appease codespell Co-authored-by: Daniel Ivanov <Daniel.K.Ivanov95@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* Initial commit * add(er721-consumer-impl) Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(er721-consumer-impl) Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(er721-consumer-impl): Change to consumable + clear consumer on transfer Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(inline-docs) Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * update(change-consumer): Fix issue on minting Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * add(tests): Add tests for the reference implementation Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * add(abi): Add ABI files Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * add(example-impl): Decouple implementation from example token Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * chore: change title of README.md Signed-off-by: Daniel Ivanov <daniel.k.ivanov95@gmail.com> * Apply editor feedback * fix typo * Remove package-lock.json to appease codespell Co-authored-by: Daniel Ivanov <Daniel.K.Ivanov95@gmail.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Daniel-K-Ivanov,
I have a few changes to suggest. I hope you don't mind me taking the liberty of making them myself! First, we no longer allow external links, so I've included your reference implementation in the assets directory. I've also added a
last-call-deadlineand removed the code snippet.Please look over these changes, and approve if they're acceptable!