Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5094: URI Format for Ethereum Network Switching #5094

Merged
merged 12 commits into from
May 31, 2022

Conversation

lucemans
Copy link
Contributor

@lucemans lucemans commented May 13, 2022

This standard includes all needed information for adding a network to a wallet via URL, by including parameters such as chainId, rpc_url, chain_name and others, such that the network configuration is provided through the URL itself.

As an extension to EIP-831 and neighboring EIP-681 and EIP-2400, this document aims to standardize the addition of new networks and switching thereof through the means of URLs. User convenience in this case is primary.

@lucemans lucemans changed the title Initial Commit 5094: URI Format for Ethereum Network Switching May 13, 2022
Co-authored-by: Jakob Helgesson <jakob.helgesson@gmail.com>
Co-authored-by: Joshua Hendrix <thejoshuahendrix@users.noreply.github.com>
@lucemans lucemans marked this pull request as ready for review May 14, 2022 21:50
@lucemans lucemans marked this pull request as draft May 14, 2022 21:51
@lucemans lucemans marked this pull request as ready for review May 14, 2022 22:25
@lucemans
Copy link
Contributor Author

Preview visible at https://eip5094.luc.page/

EIPS/eip-5094.md Outdated Show resolved Hide resolved
EIPS/eip-5094.md Outdated Show resolved Hide resolved
EIPS/eip-5094.md Outdated Show resolved Hide resolved
EIPS/eip-5094.md Show resolved Hide resolved
Co-authored-by: Micah Zoltu <micah@zoltu.net>
@eth-bot
Copy link
Collaborator

eth-bot commented May 16, 2022

All tests passed; auto-merging...

(pass) eip-5094.md

classification
updateEIP
  • passed!

@lucemans
Copy link
Contributor Author

All changes have been made, currently awaiting post approval for Ethereum Magicians

@lucemans lucemans requested a review from MicahZoltu May 17, 2022 13:07
@lucemans
Copy link
Contributor Author

@MicahZoltu I have made the appropriate changes and updated the Ethereum Magicians link! Let me know what's next!

@MicahZoltu
Copy link
Contributor

Next step is to wait for an ERC editor to review it. My initial feedback was just a cursory glance to help speed things along, but not a full review.

EIPS/eip-5094.md Show resolved Hide resolved
EIPS/eip-5094.md Outdated Show resolved Hide resolved
EIPS/eip-5094.md Outdated Show resolved Hide resolved
EIPS/eip-5094.md Outdated Show resolved Hide resolved
lucemans and others added 3 commits May 28, 2022 17:28
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@lucemans
Copy link
Contributor Author

@SamWilsn I can't seem to be able to re-request review....
But just wanted to say that the changes have been made.

MicahZoltu
MicahZoltu previously approved these changes May 29, 2022
@kodiakhq kodiakhq bot merged commit abb58e0 into ethereum:master May 31, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Initial Commit

* EIP-5094: URI Format for Ethereum Network Switching

Co-authored-by: Jakob Helgesson <jakob.helgesson@gmail.com>
Co-authored-by: Joshua Hendrix <thejoshuahendrix@users.noreply.github.com>

* EIP-5094: Updated Authors

* EIP-5094: URL and Rationale

* Update EIPS/eip-5094.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Update EIPS/eip-5094.md

* Introduce Ethereum Magicians forum link

* Shift optional /

* Add bridge phrasing

* Update EIPS/eip-5094.md

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Update EIPS/eip-5094.md

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

* Update eip-5094.md

Co-authored-by: Jakob Helgesson <jakob.helgesson@gmail.com>
Co-authored-by: Joshua Hendrix <thejoshuahendrix@users.noreply.github.com>
Co-authored-by: Micah Zoltu <micah@zoltu.net>
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants