Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC4907： Change status to Last Call #5098

Merged
merged 8 commits into from
May 31, 2022
Merged

ERC4907： Change status to Last Call #5098

merged 8 commits into from
May 31, 2022

Conversation

emojidao
Copy link
Contributor

Change status to Last Call

@eth-bot
Copy link
Collaborator

eth-bot commented May 17, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-4907.md

classification
updateEIP
  • passed!

@poojaranjan poojaranjan mentioned this pull request May 17, 2022
Closed
lightclient
lightclient requested changes May 17, 2022
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In "Backward Compatibility" please replace "ERC721" with "ERC-721". Looks good otherwise.

@emojidao emojidao requested a review from lightclient May 17, 2022 15:35
@0xanders
Copy link
Contributor

Hi @lightclient , I see this pr has been approved at EIP editor apprenticeship meeting, could you pls approve this pr and set the last call date?

@MicahZoltu MicahZoltu closed this May 31, 2022
@MicahZoltu MicahZoltu reopened this May 31, 2022
@eth-bot eth-bot enabled auto-merge (squash) May 31, 2022 06:44
MicahZoltu
MicahZoltu reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

run in Terminal：
```
truffle test ./test/test.js
```

the chances that this works at an undefined point in the future approach 0 as the distance between now and then approach infinity. In other words, please remove this as it will almost certainly break, and doesn't provide significant value toward standardization.

@eth-bot eth-bot merged commit 65b55a3 into ethereum:master May 31, 2022
@0xanders 0xanders deleted the ERC4907 branch June 6, 2022 15:40
@0xGh
Copy link
Contributor

0xGh commented Jun 10, 2022 •
edited
Loading

Hi there folks! I just learnt about this proposal and I wanted to chime in and ask what would be the best place to chat about design decisions eg. user vs holder or why userOf doesn't return a tuple or a struct

@MicahZoltu
Copy link
Contributor

what would be the best place to chat about design decisions

The discussions-to link, which is in the header of the EIP: https://ethereum-magicians.org/t/idea-erc-721-user-and-expires-extension/8572

nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@emojidao @0xanders @nachomazzara
ERC4907： Change status to Last Call (ethereum#5098)
a1d3a6b 
* Mark ERC-4907 for Review

* optimize for gas saving

* Change status to Last Call

* Change ERC721 to ERC-721

* add last-call-deadline

Co-authored-by: Anders <anders@emojidao.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu left review comments

@0xanders 0xanders 0xanders approved these changes

@ed738 ed738 ed738 approved these changes

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@emojidao @eth-bot @0xanders @0xGh @MicahZoltu @lightclient @ed738