EIP3156: small fix in code example #5104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed comment in code example. The fee is in bps units (see in `_flashFee`, division by 10,000) -> hence 1 unit of fee is 0.01%
All tests passed; auto-merging...(pass) eip-3156.md
|
|
I approve of this change. Thanks @davidbrai. |
fubuloubu
approved these changes
May 23, 2022
|
Bot fixed, this still needs an approval from @lightclient @axic or @SamWilsn |
DELJUJAZI
approved these changes
May 29, 2022
DELJUJAZI
approved these changes
May 30, 2022
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
Fixed comment in code example. The fee is in bps units (see in `_flashFee`, division by 10,000) -> hence 1 unit of fee is 0.01%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed comment in code example.
The fee is in bps units (see in
_flashFee, division by 10,000) -> hence 1 unit of fee is 0.01%@alcueca