Add initial draft for Name-bound tokens #5107

TimDaub · 2022-05-24T13:58:33Z

Co-Authors @enricobottazzi @TheWaler on hackmd:
https://hackmd.io/nbwzGZcHQaqZXHyuCSar6g

@enricobottazzi

- Co-Authors @enricobottazzi @TheWaler on hackmd: https://hackmd.io/nbwzGZcHQaqZXHyuCSar6g

MicahZoltu · 2022-05-26T12:15:58Z

EIPS/eip-xxxx.md

+  /// @dev This emits when ownership between ENS nodes of any NBT changes by any mechanism.
+  ///  This event emits when NBTs are created (`from` == 0x0) and destroyed
+  ///  (`to` == 0x0).
+  event Transfer(bytes32 indexed _from, bytes32 indexed _to, uint256 indexed _id);


Why not have a mint and burn event instead? Seems like that would be more clear than Transfer(0, ...) and Transfer(..., 0, ...)

That is the "industry standard" with all tokens 😬

MicahZoltu · 2022-05-26T12:16:43Z

EIPS/eip-xxxx.md

+
+We have adopted the [`EIP-165`](./eip-165.md) and `ERC721Metadata` functions purposefully to create a high degree of backward compatibility with [`EIP-721`](./eip-721.md). We have deliberately used [`EIP-721`](./eip-721.md) terminology such as `function ownerOf(...)` and `event Transfer` to minimize the effort of familiarization for `EIP-XXXX` implementers already familiar with, e.g., [`EIP-20`](./eip-20.md) or [`EIP-721`](./eip-721.md).
+
+## Copyright


Security Considerations section is required.

EIPS/eip-xxxx.md

MicahZoltu · 2022-05-26T12:18:27Z

EIPS/eip-xxxx.md

+
+## Backwards Compatibility
+
+We have adopted the [`EIP-165`](./eip-165.md) and `ERC721Metadata` functions purposefully to create a high degree of backward compatibility with [`EIP-721`](./eip-721.md). We have deliberately used [`EIP-721`](./eip-721.md) terminology such as `function ownerOf(...)` and `event Transfer` to minimize the effort of familiarization for `EIP-XXXX` implementers already familiar with, e.g., [`EIP-20`](./eip-20.md) or [`EIP-721`](./eip-721.md).


This should be in the rationale, rather than the backwards compatibility section.

Co-authored-by: Micah Zoltu <micah@zoltu.net>

qingfeng · 2022-05-29T07:55:20Z

Is this an attempt at SBT tokens?

axic · 2022-05-29T10:54:26Z

EIPS/eip-xxxx.md

+/// @title Name-bound tokens
+/// @dev See https://eips.ethereum.org/EIPS/eip-XXXX
+///  Note: the ERC-165 identifier for this interface is 0x6352211e.
+interface IERCXXXX /* is ERC165, ERC721Metadata */ {


This interface does not seem to define anything really. Is this still work in progress?

All of this can be accomplished by 721 or 1155. What you may want to specify is a getter function signaling whether a token is "soulbound" or not, but enforcement of that via transfer is still up to the particular token.

I disagree on this I think. The specification for a soulbound token defines ownerOf and it defines that the result of ownerOf is immutable across temporally disconnected calls. This means that if you call ownerOf and get back XXX, you can be confident that if you call ownerOf again at any point in the future you would get the same result.

@axic would it help if along with the interface definition, we checked in a reference implementation to this PR?

This is an interface. The only thing what can be prescribed is what the semantics should be, but it cannot be enforced via an interface description. Reference implementations are out of scope.

lightclient

I think you should consider working together with @MicahZoltu since you both are pursuing a "soulbound" token standard. (see #5114)

EIPS/eip-xxxx.md

TimDaub · 2022-05-31T19:46:48Z

I think you should consider working together with @MicahZoltu since you both are pursuing a "soulbound" token standard. (see #5114)

If you look on Ethereum Magicians and the PRS here on GitHub you'll see that @MicahZoltu and I are indeed closely interating albeit having varying opinions. I think their Soulbound Badges are cool and @MicahZoltu was eager to contribute a lot to 4973.

But this proposal is specifically about binding tokens to an ENS hashnode and so it is quite different from what's suggested elsewhere.

Pandapip1 · 2022-07-15T16:49:02Z

@TimDaub Please push an empty commit so that the new CI can run.

eth-bot · 2022-07-16T07:35:49Z

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) EIPS/eip-xxxx.md

classification
`ambiguous`

'EIPS/eip-xxxx.md' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

Pandapip1 · 2022-07-16T12:00:10Z

EIPS/eip-xxxx.md

@@ -0,0 +1,86 @@
+---
+eip: 5107


Please change the file name.

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

TimDaub · 2022-07-26T12:38:50Z

Is this an attempt at SBT tokens?

yes

TimDaub · 2022-07-26T12:40:08Z

I'm closing this PR, but since it's licensed as CC0, anyone can repropose it and merge it.

github-actions · 2022-07-26T12:41:48Z

The commit 57d60d3 (as a parent of e799739) contains errors. Please inspect the Run Summary for details.

TimDaub added 3 commits May 24, 2022 15:57

Add initial draft for Name-bound tokens

8bbfb58

- Co-Authors @enricobottazzi @TheWaler on hackmd: https://hackmd.io/nbwzGZcHQaqZXHyuCSar6g

Add Enrico's nickname as co-author

9c73a0a

Add discussion link

ad52843

MicahZoltu reviewed May 26, 2022

View reviewed changes

MicahZoltu suggested changes May 26, 2022

View reviewed changes

Update EIPS/eip-xxxx.md

5360770

Co-authored-by: Micah Zoltu <micah@zoltu.net>

axic reviewed May 29, 2022

View reviewed changes

poojaranjan mentioned this pull request May 31, 2022

EIP editor apprenticeship meeting 18 ethcatherders/EIPIP#140

Closed

lightclient requested changes May 31, 2022

View reviewed changes

EIPS/eip-xxxx.md Outdated Show resolved Hide resolved

EIPS/eip-xxxx.md Outdated Show resolved Hide resolved

MicahZoltu closed this Jul 16, 2022

MicahZoltu reopened this Jul 16, 2022

eth-bot added the ambiguous label Jul 16, 2022

Pandapip1 reviewed Jul 16, 2022

View reviewed changes

EIPS/eip-xxxx.md

@@ -0,0 +1,86 @@

---

eip: 5107

Copy link

Member

Pandapip1 Jul 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the file name.

Update EIPS/eip-xxxx.md

57d60d3

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

TimDaub closed this Jul 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial draft for Name-bound tokens #5107

Add initial draft for Name-bound tokens #5107

TimDaub commented May 24, 2022

MicahZoltu May 26, 2022

axic May 29, 2022

MicahZoltu May 26, 2022

MicahZoltu May 26, 2022

qingfeng commented May 29, 2022

axic May 29, 2022

MicahZoltu May 30, 2022

TimDaub May 30, 2022 •

edited

Loading

axic May 31, 2022

lightclient left a comment

TimDaub commented May 31, 2022

Pandapip1 commented Jul 15, 2022

eth-bot commented Jul 16, 2022

Pandapip1 Jul 16, 2022

TimDaub commented Jul 26, 2022

TimDaub commented Jul 26, 2022

github-actions bot commented Jul 26, 2022


		We have adopted the [`EIP-165`](./eip-165.md) and `ERC721Metadata` functions purposefully to create a high degree of backward compatibility with [`EIP-721`](./eip-721.md). We have deliberately used [`EIP-721`](./eip-721.md) terminology such as `function ownerOf(...)` and `event Transfer` to minimize the effort of familiarization for `EIP-XXXX` implementers already familiar with, e.g., [`EIP-20`](./eip-20.md) or [`EIP-721`](./eip-721.md).

		## Copyright


		## Backwards Compatibility

		We have adopted the [`EIP-165`](./eip-165.md) and `ERC721Metadata` functions purposefully to create a high degree of backward compatibility with [`EIP-721`](./eip-721.md). We have deliberately used [`EIP-721`](./eip-721.md) terminology such as `function ownerOf(...)` and `event Transfer` to minimize the effort of familiarization for `EIP-XXXX` implementers already familiar with, e.g., [`EIP-20`](./eip-20.md) or [`EIP-721`](./eip-721.md).

Add initial draft for Name-bound tokens #5107

Add initial draft for Name-bound tokens #5107

Conversation

TimDaub commented May 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingfeng commented May 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimDaub May 30, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lightclient left a comment

Choose a reason for hiding this comment

TimDaub commented May 31, 2022

Pandapip1 commented Jul 15, 2022

eth-bot commented Jul 16, 2022

(fail) EIPS/eip-xxxx.md

Choose a reason for hiding this comment

TimDaub commented Jul 26, 2022

TimDaub commented Jul 26, 2022

github-actions bot commented Jul 26, 2022

TimDaub May 30, 2022 •

edited

Loading