Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself (@Pandapip1) as an editor #5123

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Add myself (@Pandapip1) as an editor #5123

merged 1 commit into from
Jun 14, 2022

Conversation

Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Jun 1, 2022

I don't think there's anything special I need to put here, so I'm writing this sentence because it feels incorrect to leave a form field blank.

EDIT: I do have something to put here. EIP Editors - do NOT approve this, signal approval with a comment instead. @eth-bot will auto-merge this with only one approval.

@eth-bot
Copy link
Collaborator

eth-bot commented Jun 1, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) .github/workflows/auto-merge-bot.yml

classification
ambiguous
  • '.github/workflows/auto-merge-bot.yml' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

@MicahZoltu
Copy link
Contributor

Lets wait to get feedback from @axic @lightclient @gcolvin before merging. If we haven't heard from them in 3 weeks mention me and I'll merge.

@lightclient
Copy link
Member

👍 from me.

@Pandapip1
Copy link
Member Author

Bump. @axic @gcolvin

@MicahZoltu
Copy link
Contributor

Given we have 3 editors in support, lets drop the wait time to 1 more week (when this post says "7 days ago"). Ping me at that time and assuming no negative feedback I'll merge.

@gcolvin
Copy link
Contributor

gcolvin commented Jun 13, 2022

Sorry I missed this. Good by me.

@MicahZoltu MicahZoltu merged commit 76a8234 into ethereum:master Jun 14, 2022
@Pandapip1 Pandapip1 deleted the patch-13 branch June 14, 2022 11:14
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants