Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-5131: ENS Subdomain Authentication #5131
Add EIP-5131: ENS Subdomain Authentication #5131
Changes from 8 commits
02fdd31
d926f0a
3e3b45c
069848e
03d63ba
31fd495
d779068
a24fa63
e51e8ed
5676cce
3c70189
c0c8ded
713c03f
51a0753
dc3ad8a
1c3abd7
54a20ef
00458df
47558a2
8360e7e
bb9dace
fc02098
248dad3
c1b51af
b59c292
9bd601c
7d59810
ace2c39
8ce77e1
1f7f35c
0b880a1
43f8ba4
bf02f83
c3c8687
a9fe2e6
a7c605a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this sounds like motivation, rather than abstract. The abstract should be a simplified and human readable description of the specification and should not include commentary on "why".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be beneficial for the readers understanding to underline the importance of the reverse record here. Maybe adding something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I think this section is reading more like motivation than rationale. I think you should consider moving a fair bit of this content above and focus on answering why certain design decisions were chosen over other decisions here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have trouble understanding what is meant by
secure server
. Does this refer to the node provider? Otherwise, I could run the above js code also on a web client.