Update EIP-2612: Move to Last Call #5196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move eip-2612 to Last Call
All tests passed; auto-merging...(pass) eip-2612.md
|
lightclient
approved these changes
Jul 3, 2022
SamWilsn
requested changes
Jul 3, 2022
There was a problem hiding this comment.
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
27 | While ERC-20 tokens have become ubiquitous in the Ethereum ecosystem, their status remains that of second class tokens from the perspective of the protocol. The ability for users to interact with Ethereum without holding any ETH has been a [long outstanding goal](./eip-101.md) and the [subject](./eip-1077.md) [of](./eip-777.md) [many](https://github.com/ethereum/EIPs/issues/1776) [EIPs](./eip-1271.md).
|
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
29 | So far, many of these proposals have seen very little adoption, and the ones that have been adopted (such as [ERC-777](./eip-777.md)), introduce a lot of additional functionality, causing [unexpected behavior in mainstream contracts](https://medium.com/consensys-diligence/uniswap-audit-b90335ac007).
|
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
154 | The `permit` function is sufficient for enabling any operation involving ERC-20 tokens to be paid for using the token itself, rather than using ETH.
|
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
173 | There is also an implementation in the token [`Stake`](https://etherscan.io/address/0x0Ae055097C6d159879521C384F1D2123D1f195e6#code) with the same ABI as `dai` but with different semantics: it lets users issue "expiring approvals", that only allow `transferFrom` to occur while `expiry >= block.timestamp`.
|
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
175 | The specification presented here is in line with the implementation in [Uniswap-v2](https://github.com/uniswap/uniswap-v2-core).
|
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
184 | [UniswapV2ERC20.sol](https://github.com/Uniswap/uniswap-v2-core/blob/master/contracts/UniswapV2ERC20.sol)
|
error[markdown-rel-links]: non-relative link or image
--> /tmp/eip-2612.md
|
194 | The standard [ERC-20 race condition for approvals](https://swcregistry.io/docs/SWC-114) applies to `permit` as well.
|
|
@z0r0z please push an empty commit and then fix the CI errors. Thanks! |
MrChico
approved these changes
Aug 15, 2022
eth-bot
approved these changes
Aug 15, 2022
xinbenlv
reviewed
Aug 16, 2022
| @@ -4,7 +4,8 @@ title: permit – 712-signed approvals | |||
| description: ERC-20 approvals via secp256k1 signatures | |||
| author: Martin Lundfall (@Mrchico) | |||
| discussions-to: https://github.com/ethereum/EIPs/issues/2613 | |||
| status: Review | |||
| status: Last Call | |||
| last-call-deadline: 2022-07-30 | |||
| type: Standards Track | |||
| category: ERC | |||
| created: 2020-04-13 | |||
There was a problem hiding this comment.
Just to confirm, is it the author's intention to not follow EIP-165? I believe it's the author's judgement call but just to make sure it's a conscious decision.
Pandapip1
changed the title
|
Superseded by #5506 |
auto-merge was automatically disabled
September 1, 2022 01:51
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eip-2612 has been discussed for 2 years and seen wide implementation in production (uniswapV2) and in contract libraries like openzeppelin and solmate. It seems time to finalize and move this as a standard extension for erc20 fungible tokens.