Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-5219: Contract Resource Requests #5219

Merged
merged 23 commits into from
Jul 28, 2022
Merged

Add EIP-5219: Contract Resource Requests #5219

merged 23 commits into from
Jul 28, 2022

Conversation

Pandapip1
Copy link
Member

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eth-bot
Copy link
Collaborator

eth-bot commented Jul 11, 2022 •
edited
Loading

All tests passed; auto-merging...

(pass) eip-5219.md

classification
updateEIP
  • passed!

(pass) assets/eip-5219/IDecentralizedApp.sol

classification
ambiguous
  • file assets/eip-5219/IDecentralizedApp.sol is associated with EIP 5219; because there are also changes being made to EIPS/eip-5219.md all changes to corresponding assets are also allowed

@Pandapip1 Pandapip1 marked this pull request as ready for review July 11, 2022 19:10
@poojaranjan poojaranjan mentioned this pull request Jul 12, 2022
Closed
MicahZoltu
MicahZoltu reviewed Jul 12, 2022
View reviewed changes
EIPS/eip-5219.md Outdated Show resolved Hide resolved
EIPS/eip-5219.md Outdated Show resolved Hide resolved
Pandapip1 and others added 2 commits July 12, 2022 17:25
@Pandapip1 @MicahZoltu
Update EIPS/eip-5219.md
d5010eb 
Co-authored-by: Micah Zoltu <micah@zoltu.net>
@Pandapip1
Add actual solution to problem
7ee5f4b
@Pandapip1
Copy link
Member Author

Re-trigger CI

@Pandapip1 Pandapip1 closed this Jul 14, 2022
@Pandapip1 Pandapip1 reopened this Jul 14, 2022
@Pandapip1 Pandapip1 changed the title Decentralized HTTP PR-5219: Decentralized HTTP Jul 19, 2022
@github-actions
Copy link

The commit f875cde (as a parent of 3354320) contains errors. Please inspect the Run Summary for details.

@Pandapip1 Pandapip1 changed the title PR-5219: Decentralized HTTP PR-5219: Contract REST Jul 25, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 25, 2022 01:31
auto-merge was automatically disabled July 25, 2022 01:40

Head branch was pushed to by a user without write access

MicahZoltu
MicahZoltu reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@MicahZoltu MicahZoltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear to me how exactly this solves the problems you proposed. We already have a mechanism for calling functions against Ethereum contracts and getting responses, along with an enchoding scheme for all of that (the solidity function call ABI). I don't understand what we gain by having a function with an abstract function calling mechanism in it.

EIPS/eip-5219.md Outdated Show resolved Hide resolved
EIPS/eip-5219.md Outdated Show resolved Hide resolved
EIPS/eip-5219.md Outdated Show resolved Hide resolved
assets/eip-5219/IDecentralizedApp.sol Outdated Show resolved Hide resolved
assets/eip-5219/IDecentralizedApp.sol Outdated Show resolved Hide resolved
assets/eip-5219/IDecentralizedApp.sol Show resolved Hide resolved
@Pandapip1
Copy link
Member Author

I don't understand what we gain by having a function with an abstract function calling mechanism in it.

Think about this EIP as standardizing a way for smart contracts to become websites. HTTP just happens to be the current standard for that, and so this EIP tries to mimic that.

@Pandapip1 Pandapip1 changed the title PR-5219: Contract REST PR-5219: Contract Resource Requests Jul 25, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 25, 2022 17:06
auto-merge was automatically disabled July 25, 2022 17:07

Head branch was pushed to by a user without write access

@github-actions
Copy link

The commit fda819c (as a parent of 49d6bbe) contains errors. Please inspect the Run Summary for details.

@Pandapip1 Pandapip1 mentioned this pull request Jul 25, 2022
Merged
@poojaranjan poojaranjan mentioned this pull request Jul 26, 2022
Closed
lightclient
lightclient approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandapip1 Pandapip1 closed this Jul 28, 2022
@Pandapip1 Pandapip1 reopened this Jul 28, 2022
@eth-bot eth-bot enabled auto-merge (squash) July 28, 2022 14:53
@eth-bot eth-bot merged commit 1231616 into ethereum:master Jul 28, 2022
@Pandapip1 Pandapip1 deleted the pandapip1-eip-dhttp branch July 28, 2022 15:08
@Pandapip1 Pandapip1 changed the title PR-5219: Contract Resource Requests Add EIP-5219: Contract Resource Requests Oct 11, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
@Pandapip1 @MicahZoltu @nachomazzara
PR-5219: Contract Resource Requests (ethereum#5219)
a740a1f 
* Add eip-dhttp

* Self-assign EIP number

* I can't believe I somehow missed that

* Update EIPS/eip-5219.md

Co-authored-by: Micah Zoltu <micah@zoltu.net>

* Add actual solution to problem

* Formatting

* Update discussions-to link

* It worked locally though!

* Add extra newline

* Remove EIP-20 reference

* Add field that I missed

* Change the name to Contract REST & make a few more changes

* Move text from abstract to motivation

* Make suggested changes

* Remove EIP-165

* Alternative mechanism described

* Get rid of all EIP references

* Extremely slim down the spec

* Make the EIP motivation a bit more clearer throughout

* Change name to "Contract Resource Requests"

* Fix typos

Co-authored-by: Micah Zoltu <micah@zoltu.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MicahZoltu MicahZoltu MicahZoltu left review comments

@lightclient lightclient lightclient approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pandapip1 @eth-bot @MicahZoltu @lightclient