Add EIP-5289: Ethereum Notary Interface #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandapip1
changed the title
All tests passed; auto-merging...(pass) eip-5289.md
(pass) assets/eip-5289/ERC5289Library.sol
(pass) assets/eip-5289/interfaces/IERC165.sol
(pass) assets/eip-5289/interfaces/IERC5289Library.sol
|
|
That was close 😓. |
|
This is cool. |
MicahZoltu
reviewed
Jul 19, 2022
Co-authored-by: Micah Zoltu <micah@zoltu.net>
|
FYI - I changed the category to interface as it is probably more appropriate for what I am trying to accomplish. |
xinbenlv
reviewed
Jul 19, 2022
Co-authored-by: xinbenlv <zzn@zzn.im>
MicahZoltu
reviewed
Jul 20, 2022
auto-merge was automatically disabled
August 5, 2022 18:26
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
August 9, 2022 15:53
Head branch was pushed to by a user without write access
SamWilsn
approved these changes
Aug 9, 2022
|
|
||
| ## Security Considerations | ||
|
|
||
| No security considerations. |
There was a problem hiding this comment.
Not required for a draft, but a note about the definition of privity and legal jurisdictions might be nice before final
Pandapip1
added a commit
to Pandapip1/EIPs
that referenced
this pull request
Aug 10, 2022
* Add eip-legal-smart-contracts * Self-assign EIP number 5289 * Add FEM link * Empty commit * Apply suggestions from code review Co-authored-by: Micah Zoltu <micah@zoltu.net> * Commit changes so far * Add custom revert reason * Make a few more changes * Not always ECDSA * Missed a # * Add language * Change name based on @xinvenlv's suggestion Co-authored-by: xinbenlv <zzn@zzn.im> * Change to multi-document libraries * Fix typo * Fix small typo * Remove a hypen * Move back to erc * Update EIPS/eip-5289.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Make documentSigned return all relevant info * Update ethereum magicians link * Add 'Smart' to title Co-authored-by: xinbenlv <zzn@zzn.im> * Ethereum Notary Interface * Remove PDF requirement * Remove reference to OZ Co-authored-by: Micah Zoltu <micah@zoltu.net> * Create SignatureChecker.sol * Create ECDSA.sol * Create Strings.sol * Create Address.sol * Create IERC1271.sol * Typo * Move some files to the assets folder * Create ERC165Storage.sol * Create ERC165.sol * Create IERC165.sol * Create IERC5289Library.sol * Use internal links * Not sure how I managed to mess that up * eipw errors * Significantly reduce the length of the messages * When you remember account abstraction is going to be a thing * Some more optimizations * Update eip-5289.md Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: xinbenlv <zzn@zzn.im>
Pandapip1
changed the title
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* Add eip-legal-smart-contracts * Self-assign EIP number 5289 * Add FEM link * Empty commit * Apply suggestions from code review Co-authored-by: Micah Zoltu <micah@zoltu.net> * Commit changes so far * Add custom revert reason * Make a few more changes * Not always ECDSA * Missed a # * Add language * Change name based on @xinvenlv's suggestion Co-authored-by: xinbenlv <zzn@zzn.im> * Change to multi-document libraries * Fix typo * Fix small typo * Remove a hypen * Move back to erc * Update EIPS/eip-5289.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Make documentSigned return all relevant info * Update ethereum magicians link * Add 'Smart' to title Co-authored-by: xinbenlv <zzn@zzn.im> * Ethereum Notary Interface * Remove PDF requirement * Remove reference to OZ Co-authored-by: Micah Zoltu <micah@zoltu.net> * Create SignatureChecker.sol * Create ECDSA.sol * Create Strings.sol * Create Address.sol * Create IERC1271.sol * Typo * Move some files to the assets folder * Create ERC165Storage.sol * Create ERC165.sol * Create IERC165.sol * Create IERC5289Library.sol * Use internal links * Not sure how I managed to mess that up * eipw errors * Significantly reduce the length of the messages * When you remember account abstraction is going to be a thing * Some more optimizations * Update eip-5289.md Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: xinbenlv <zzn@zzn.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows interoperability between Ethereum smart contracts and the real world.