-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP-5334: EIP-721 User And Expires And Level Extension #5334
Conversation
A critical exception has occurred: |
The commit de24604 (as a parent of 87c68c5) contains errors. Please inspect the Run Summary for details. |
Head branch was pushed to by a user without write access
The commit 25f5ebb (as a parent of 3447ad6) contains errors. Please inspect the Run Summary for details. |
Updated 5327 to 5334 |
The commit 7f2238f (as a parent of 143fc8c) contains errors. Please inspect the Run Summary for details. |
The commit 71995f4 (as a parent of 2eb63d5) contains errors. Please inspect the Run Summary for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference implementation should only contain the minimum code possible to exemplify an implementation of this standard. It doesn't have to be complete or even compile out of the box and it shouldn't include an entire build system, tooling, nor any extraneous features. I recommend deleting everything in assets/eip-5334
except the ERC5334.sol file.
For test cases, this should be something that is portable to any environment a future reader may be using and not tightly coupled with a particular language/test tooling. Usually this means a JSON file or something that has function, inputs, expected_outputs, expected_exceptions
or something. You may want additional columns for expected post-conditions as well.
The readme also shouldn't be included, nor should the .gitignore.
Head branch was pushed to by a user without write access
Thank you for your counsel. |
The commit 8001859 (as a parent of 2cbaf15) contains errors. Please inspect the Run Summary for details. |
The commit d9c25a7 (as a parent of 2466c55) contains errors. Please inspect the Run Summary for details. |
The commit 6ae9c42 (as a parent of d90e80f) contains errors. Please inspect the Run Summary for details. |
The commit 4d5c541 (as a parent of c0f16a8) contains errors. Please inspect the Run Summary for details. |
@lightclient, @axic, @SamWilsn, @Pandapip1 |
The commit 8c5e27a (as a parent of 13d8655) contains errors. Please inspect the Run Summary for details. |
The commit 9405585 (as a parent of f4f0350) contains errors. Please inspect the Run Summary for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest add setUserLevel() and userLevel() as an extension of EIP-4907
/// @notice Get the user level of an NFT
/// @dev The zero value indicates that there is no user
/// @param tokenId The NFT to get the user level for
/// @return The user level for this NFT
function userLevel(uint256 tokenId) external view returns(uint8);
/// @notice Set the user level of an NFT
/// @param level User level of the NFT
function SetUserLevel(uint256 tokenId, uint8 level) external view returns(uint256);
@lightclient, @SamWilsn, @Pandapip1, please compare this EIP with EIP-4907, there is a lot of the same content. So I suggest change this EIP as an extension of EIP-4907 |
Please make the required changes. They can be found in the files tab |
Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yan253319066 - if you don't like any of these changes, please feel free to revert them by submitting a PR.
…5334) * EIP5327: ERC-721 User And Expires And Level Extension * yan * yan * yan * yan * Delete unnecessary files * yan * yan * yan * yan * yan * yan * yan * Apply a few fixes Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Move Rationale to Motivation Co-authored-by: yanning <ynsz@163.com> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: