changing the ERC with EIP along with their relative links #5336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests passed; auto-merging...(pass) eip-3475.md
(pass) assets/eip-3475/Metadata.md
|
MicahZoltu
reviewed
Jul 25, 2022
|
There are merge conflicts. Please fix them. |
auto-merge was automatically disabled
July 25, 2022 14:43
Head branch was pushed to by a user without write access
Co-authored-by: Micah Zoltu <micah@zoltu.net>
|
The commit 14df9f6 (as a parent of 1224211) contains errors. Please inspect the Run Summary for details. |
|
The commit e8be585 (as a parent of 3086718) contains errors. Please inspect the Run Summary for details. |
dr-chain
approved these changes
Jul 25, 2022
|
@Pandapip1 @MicahZoltu fixed the issues, all checks are passing. |
|
I'll wait |
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
) * wip: minor changes about ERC -> EIP and spaces * EIP-N linking error validation rule patch * minor fixes * Apply suggestions from code review Co-authored-by: Micah Zoltu <micah@zoltu.net> * minor fixes * minor fix * check of this EIP rule (EIP-1) * minor refactor Co-authored-by: dr-chain <12458730+dr-chain@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authors @yuliu-debond and @malikdhruv007
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: