Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-712: Fix eth_signTypedData definition #5457

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Update EIP-712: Fix eth_signTypedData definition #5457

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6fe3596
EIP-712: fix `eth_signTypedData` definition
wchargin Aug 14, 2022
5fac9e9
[eip-712-eth-signtypeddata: update syntax and verbiage slightly]
wchargin Aug 18, 2022
29bd68c
Merge branch 'master' into wchargin-eip-712-eth-signtypeddata
Pandapip1 Aug 26, 2022
51ff866
Remove the correct stuff
Pandapip1 Feb 22, 2023
92b0d2b
Fix another issue
Pandapip1 Feb 22, 2023
75be219
Never mind, this looks correct
Pandapip1 Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions EIPS/eip-712.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ The method `eth_signTypedData` is added to the Ethereum JSON-RPC. The method par

#### eth_signTypedData

The sign method calculates an Ethereum specific signature with: `sign(keccak256("\x19Ethereum Signed Message:\n" + len(message) + message)))`.

By adding a prefix to the message makes the calculated signature recognisable as an Ethereum specific signature. This prevents misuse where a malicious DApp can sign arbitrary data (e.g. transaction) and use the signature to impersonate the victim.
The sign method calculates an Ethereum specific signature with: `sign(keccak256("\x19\x01" ‖ domainSeparator ‖ hashStruct(message)))`, as defined above.

**Note**: the address to sign with must be unlocked.

Expand Down