ADD: EIP-5489 NFT Hyperlink Extension #5489

coderfengyun · 2022-08-18T08:21:41Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

eth-bot · 2022-08-18T08:22:35Z

A critical exception has occurred:
Message: pr 5489 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

EIPS/eip-5438.md

assets/eip-5438/contracts/ERC5438.sol

assets/eip-5438/.gitignore

assets/eip-5438/contracts/ERC5438.sol

assets/eip-5438/contracts/IERC5438.sol

assets/eip-5438/package.json

abcoathup · 2022-08-19T03:47:42Z

@Pandapip1 did this EIP get renamed from EIP5489 to EIP5438?

coderfengyun · 2022-08-19T04:10:48Z

Nope, it has no relation with 5489

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

abcoathup · 2022-08-19T05:09:53Z

Nope, it has no relation with 5489

Generally the EIP# is the PR# unless the EIP editor assigns a different number. The PR is 5489.

coderfengyun · 2022-08-19T06:11:40Z

OK, I'll fix it.

coderfengyun · 2022-08-19T06:19:29Z

@Pandapip1 did this EIP get renamed from EIP5489 to EIP5438?

Have fixed it.

Pandapip1 · 2022-08-19T11:47:40Z

EIPS/eip-5489.md

+
+However, there hasn’t been an effective approach to providing avenues of continued monetization for community holders. Going through all the NFT-related EIPs, the solutions to "making NFTs profitable" are limited to transfers ([EIP-721](./eip-721.md)), rental and mortgage ([EIP-4907](./eip-4907.md)).
+
+Inspired by hyperlink, the essence of World Wide Web, the proposed hNFT standard positions NFT as the medium for Web 3.0. The hNFT standard endows NFTs with a hyperlink extension so that it is possible to exercise the `fructus` right, meanwhile, keeps the `abusus`. With hyperlink extension, NFT owners can earn profit by authorizing any hyperlink slot to an address.


Suggested change

Inspired by hyperlink, the essence of World Wide Web, the proposed hNFT standard positions NFT as the medium for Web 3.0. The hNFT standard endows NFTs with a hyperlink extension so that it is possible to exercise the `fructus` right, meanwhile, keeps the `abusus`. With hyperlink extension, NFT owners can earn profit by authorizing any hyperlink slot to an address.

Required: Not motivation.

@Pandapip1 How about just keeping "With hyperlink extension, NFT owners can earn profit by authorizing any hyperlink slot to an address." this sentence ?

Again, that describes the solution, not the problem, and so would belong in the Abstract.

I see, the core problems are:

no on-chain way to take advantage of NFT's influence without affecting ownership for now.

no standard on how to use in URI in NFT relative standard

@Pandapip1 How about just list these two as the motivation?

That seems good to me.

@Pandapip1 I've modified the motivation.

EIPS/eip-5489.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

EIPS/eip-5489.md

SamWilsn · 2022-08-23T15:53:00Z

EIPS/eip-5489.md

+---
+eip: 5489
+title: NFT hyperlink extension
+description: hyperlink extension for EIP-721


This description is just a rewording of the title. I'd try to expand a little bit: maybe include what a hyperlink for NFTs means?

The meaning can be extended by usages. For example, NFTs can be taken as decentralized medium which can attract users' attention.

I've rephrase this description.

SamWilsn · 2022-08-23T15:53:31Z

EIPS/eip-5489.md

+
+## Abstract
+
+This EIP proposes a new extension for NFTs (non-fungible token, aka [EIP-721](./eip-721.md)): nft-hyperlink-extention (hNFT), embedding NFTs with hyperlinks, referred to as “hNFTs”. As owners of hNFTs, users may authorize a URL slot to a specific address which can be either an externally-owned account (EOA) or a contract address and hNFT owners are entitled to revoke that authorization at any time. The address which has slot authorization can manage the URI of that slot.


Is it a URI slot, or a URL slot?

In my original thought, It's URL slot.

SamWilsn · 2022-08-23T15:54:08Z

EIPS/eip-5489.md

+
+## Abstract
+
+This EIP proposes a new extension for NFTs (non-fungible token, aka [EIP-721](./eip-721.md)): nft-hyperlink-extention (hNFT), embedding NFTs with hyperlinks, referred to as “hNFTs”. As owners of hNFTs, users may authorize a URL slot to a specific address which can be either an externally-owned account (EOA) or a contract address and hNFT owners are entitled to revoke that authorization at any time. The address which has slot authorization can manage the URI of that slot.


I'd like to see the abstract explain (very briefly) what the hyperlink is for.

I've add usage in advertisement industry.

SamWilsn · 2022-08-23T15:56:01Z

EIPS/eip-5489.md

+NFTs have entered mainstream consciousness in a big way as NFT trading volume spiked 21,000% to more than $17 billion in 2021. Despite NFTs’ monumental rise as blockchain-based digital assets, we are just starting to scratch the surface of what is possible with NFTs.
+
+The emergence of NFTs brings more possibilities for creators and Web3 projects to build up decentralized communities, which also shifts the previous company-consumer relationship to more of a partnership. Each NFT holder is entitled to trade, promote, or create based on their NFTs to make profits. 


I think this information is too broadly applicable, and doesn't really have anything to do with hyperlinks in EIP-721 tokens.

Will rephrase this paragraph.

@SamWilsn Rephrased.

SamWilsn · 2022-08-23T15:58:04Z

EIPS/eip-5489.md

+
+To establish standardization for NFT hyperlinks, it is important to share a unified standard so as to facilitate collaboration among all applications.
+
+Right to permission access to information—could be composed with “usus,” “abusus,” and “fructus” to create a nuanced constellation of access rights.


Please use a consistent style (backticks or quotes) for these terms.

This paragraph is removed.

SamWilsn · 2022-08-23T15:59:41Z

EIPS/eip-5489.md

+
+### NFT hyperlink extension
+
+This EIP extends EIP-721 with a `mapping<TokenId, mapping<SlotManagerAddress, uri>>`. The mapping means `TokenId` identified NFT has authorized `SlotManagerAddress` to manage the `uri` which is identified by `SlotManagerAddress`.


This is unusual syntax for a mapping.

It's also an implementation detail. You shouldn't specify how contracts implement your standard, just the externally visible functions.

SamWilsn · 2022-08-23T16:02:33Z

EIPS/eip-5489.md

+This EIP extends EIP-721 with a `mapping<TokenId, mapping<SlotManagerAddress, uri>>`. The mapping means `TokenId` identified NFT has authorized `SlotManagerAddress` to manage the `uri` which is identified by `SlotManagerAddress`.
+
+Besides, extension also provide the supporting facilities, such as
+1. authorizeSlot/revokeSlot call pair used to manage slot authorization, and SlotAuthorizationCreate/Revoked event pair used to announce authorization management happens.
+2. setSlotUri/getSlotUri call pair used to manage/view uri on slot, and SlotUriUpdated used to announce uri management happens.


I don't think this subsection introduces anything that wouldn't be better suited in the documentation alongside the solidity interface below.

SamWilsn · 2022-08-23T16:03:12Z

EIPS/eip-5489.md

+    event SlotAuthorizationCreated(uint256 tokenId, address slotManagerAddr);
+
+    /**
+     * @dev this event emits when the authorization on slot `slotManagerAddr` of token `tokenId` is revoked.
+     * So, the corresponding DApp can handle this to stop on-going incentives or rights
+     */
+    event SlotAuthorizationRevoked(uint256 tokenId, address slotManagerAddr);
+
+    /**
+     * @dev this event emits when the uri on slot `slotManagerAddr` of token `tokenId` has been updated to `uri`.
+     */
+    event SlotUriUpdated(uint256 tokenId, address slotManagerAddr, string uri);


I assume some of these event parameters should be indexed?

Will fix it.

SamWilsn · 2022-08-23T16:03:57Z

EIPS/eip-5489.md

+     * @dev
+     * returns the latest uri of an slot on a token, which is indicated by `tokenId`, `slotManagerAddr`
+     */
+    function getSlotUri(uint256 tokenId, address slotManagerAddr)


Should probably be slotURI for consistency with the other standards.

Do you mean eip-3525 ?

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Pandapip1

This is fine. There are some things that would be good to fix, but they aren't blockers.

* ADD: EIP-5438 * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update assets/eip-5438/contracts/ERC5438.sol Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update assets/eip-5438/contracts/IERC5438.sol Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * MOD: use the correct magician link * FIX: Walidator warnings * Update EIPS/eip-5438.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * FIX: Walidator warnings * DEL: packaging / workspace files, and external references * MOD: EIP number from 5438 -> 5489 * MOD: rename 5438.md -> 5489.md * MOD: motivation grammar * Update EIPS/eip-5489.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5489.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5489.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5489.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5489.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * MOD: motivation as review comment * MOD: motivation * MOD: description, abstract, event definitions * DEL: Spec.NFT Hyperlink Extension Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

coderfengyun requested a review from eth-bot as a code owner August 18, 2022 08:21

github-actions bot added classification: new EIP labels Aug 18, 2022

Pandapip1 suggested changes Aug 18, 2022

View reviewed changes

github-actions bot added the waiting: walidator to pass label Aug 19, 2022

coderfengyun and others added 22 commits August 19, 2022 12:25

ADD: EIP-5438

5f5a8de

Update EIPS/eip-5438.md

b69e92d

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

dab79a1

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

a4c6e20

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

2d6b56d

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

91b0527

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update assets/eip-5438/contracts/ERC5438.sol

359e99f

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update assets/eip-5438/contracts/IERC5438.sol

7b7074f

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

8e5f39b

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

ae6140c

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

a3c7e98

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

0e7a342

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

3616326

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

c28bd4a

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

2251178

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

931306b

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

fc44fb6

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5438.md

0607d1b

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

MOD: use the correct magician link

88e8680

FIX: Walidator warnings

27e2c54

Update EIPS/eip-5438.md

0357b5e

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

FIX: Walidator warnings

95d9e6b

DEL: packaging / workspace files, and external references

738a602

coderfengyun force-pushed the master branch from 0d0a415 to 738a602 Compare August 19, 2022 04:27

MOD: EIP number from 5438 -> 5489

0b9619f

coderfengyun changed the title ~~ADD: EIP-5438~~ ADD: EIP-5489 NFT Hyperlink Extension Aug 19, 2022

coderfengyun added 2 commits August 19, 2022 14:48

MOD: rename 5438.md -> 5489.md

d7a19d7

MOD: motivation grammar

b427af6

Pandapip1 suggested changes Aug 19, 2022

View reviewed changes

coderfengyun and others added 4 commits August 19, 2022 20:03

Update EIPS/eip-5489.md

29cdaa3

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5489.md

71ba534

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5489.md

d4c1c97

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5489.md

e9a527c

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Pandapip1 removed the waiting: walidator to pass label Aug 23, 2022

poojaranjan mentioned this pull request Aug 23, 2022

EIP editor apprenticeship meeting 24 ethcatherders/EIPIP#173

Closed

SamWilsn reviewed Aug 23, 2022

View reviewed changes

coderfengyun and others added 7 commits August 24, 2022 12:25

Update EIPS/eip-5489.md

9617f64

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Merge branch 'ethereum:master' into master

6a06d1d

Merge branch 'ethereum:master' into master

5f918d9

MOD: motivation as review comment

e4deaa5

MOD: motivation

7d8dd1c

MOD: description, abstract, event definitions

df1a273

DEL: Spec.NFT Hyperlink Extension

a5444b6

Pandapip1 approved these changes Aug 25, 2022

View reviewed changes

eth-bot enabled auto-merge (squash) August 25, 2022 14:30

eth-bot approved these changes Aug 25, 2022

View reviewed changes

eth-bot merged commit 2431f0c into ethereum:master Aug 25, 2022


		However, there hasn’t been an effective approach to providing avenues of continued monetization for community holders. Going through all the NFT-related EIPs, the solutions to "making NFTs profitable" are limited to transfers ([EIP-721](./eip-721.md)), rental and mortgage ([EIP-4907](./eip-4907.md)).

		Inspired by hyperlink, the essence of World Wide Web, the proposed hNFT standard positions NFT as the medium for Web 3.0. The hNFT standard endows NFTs with a hyperlink extension so that it is possible to exercise the `fructus` right, meanwhile, keeps the `abusus`. With hyperlink extension, NFT owners can earn profit by authorizing any hyperlink slot to an address.


		## Abstract

		This EIP proposes a new extension for NFTs (non-fungible token, aka [EIP-721](./eip-721.md)): nft-hyperlink-extention (hNFT), embedding NFTs with hyperlinks, referred to as “hNFTs”. As owners of hNFTs, users may authorize a URL slot to a specific address which can be either an externally-owned account (EOA) or a contract address and hNFT owners are entitled to revoke that authorization at any time. The address which has slot authorization can manage the URI of that slot.

		NFTs have entered mainstream consciousness in a big way as NFT trading volume spiked 21,000% to more than $17 billion in 2021. Despite NFTs’ monumental rise as blockchain-based digital assets, we are just starting to scratch the surface of what is possible with NFTs.

		The emergence of NFTs brings more possibilities for creators and Web3 projects to build up decentralized communities, which also shifts the previous company-consumer relationship to more of a partnership. Each NFT holder is entitled to trade, promote, or create based on their NFTs to make profits.


		To establish standardization for NFT hyperlinks, it is important to share a unified standard so as to facilitate collaboration among all applications.

		Right to permission access to information—could be composed with “usus,” “abusus,” and “fructus” to create a nuanced constellation of access rights.


		### NFT hyperlink extension

		This EIP extends EIP-721 with a `mapping<TokenId, mapping<SlotManagerAddress, uri>>`. The mapping means `TokenId` identified NFT has authorized `SlotManagerAddress` to manage the `uri` which is identified by `SlotManagerAddress`.

ADD: EIP-5489 NFT Hyperlink Extension #5489

ADD: EIP-5489 NFT Hyperlink Extension #5489

Conversation

coderfengyun commented Aug 18, 2022

eth-bot commented Aug 18, 2022 • edited Loading

abcoathup commented Aug 19, 2022

coderfengyun commented Aug 19, 2022 • edited Loading

abcoathup commented Aug 19, 2022

coderfengyun commented Aug 19, 2022

coderfengyun commented Aug 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderfengyun Aug 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderfengyun Aug 24, 2022 • edited Loading

Choose a reason for hiding this comment

coderfengyun Aug 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderfengyun Aug 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

eth-bot commented Aug 18, 2022 •

edited

Loading

coderfengyun commented Aug 19, 2022 •

edited

Loading

coderfengyun Aug 24, 2022 •

edited

Loading

coderfengyun Aug 24, 2022 •

edited

Loading

coderfengyun Aug 25, 2022 •

edited

Loading

coderfengyun Aug 25, 2022 •

edited

Loading