Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-5553: Intellectual Property Representation with Royalties #5553

Merged
merged 51 commits into from
Sep 1, 2022

Conversation

royosherove
Copy link
Contributor

A standardized way to represent intellectual works on chain, along with a refined royalty representation mechanism and associated metadata. This standard is not associated with a specific type of work and could represent many types of works such as musical works, videos, books, images and more.
The standard is kept very generic on purpose to allow the industry to evolve new ecosystems that can all rely on the same basic standard at their core

@royosherove royosherove requested a review from eth-bot as a code owner August 28, 2022 14:48
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Aug 28, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 28, 2022

All tests passed; auto-merging...

(pass) eip-5553.md

classification
updateEIP
  • passed!

@Pandapip1 Pandapip1 changed the title Works & Royalty Interest Representation Add EIP-5553: Works & Royalty Interest Representation Aug 28, 2022
EIPS/eip-5553.md Outdated Show resolved Hide resolved
EIPS/eip-5553.md Outdated Show resolved Hide resolved
EIPS/eip-5553.md Outdated Show resolved Hide resolved
EIPS/eip-5553.md Outdated Show resolved Hide resolved
EIPS/eip-5553.md Outdated Show resolved Hide resolved
EIPS/eip-5553.md Outdated Show resolved Hide resolved
@royosherove royosherove changed the title Add EIP-5553: Works & Royalty Interest Representation Add EIP-5553: Intellectual Property Representation with Royalties Aug 30, 2022
@royosherove
Copy link
Contributor Author

Folks, thanks for your time.
I keep seeing "Pandapip1 requested changes" but all change requests have been resolved. What am I missing?

Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the grammar in the specification section.

@royosherove
Copy link
Contributor Author

Please fix the grammar in the specification section.

OK I looked at all the grammar issues I could find and fixed them. Not sure which ones you meant.

If you point out something more specific I'm happy to fix it.

SongRegistration -> MusicalIP
royaltyInterestTokens -> royaltyRightsTokens
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run this through Grammarly. It'll catch things like L41 not starting with a capital letter and a duplicated word on L249.

@royosherove
Copy link
Contributor Author

Anything else keeping this from being merged?

@Pandapip1
Copy link
Member

Anything else keeping this from being merged?

Grammar mistakes. I'll run it through Grammarly myself I guess.

@Pandapip1 Pandapip1 dismissed a stale review via 215d74c September 1, 2022 12:29
@eth-bot eth-bot enabled auto-merge (squash) September 1, 2022 12:32
@eth-bot eth-bot merged commit f57aa37 into ethereum:master Sep 1, 2022
@royosherove
Copy link
Contributor Author

royosherove commented Sep 1, 2022 via email

nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
…hereum#5553)

* ERC821

* wording

* discussions link

* fixes for EIP checks

* fix bot reeview changes

* fix validator checks

* typos

* typos

* Assign EIP-5553

* Update eip-5553.md

wording

* Update eip-5553.md

* Fix codespell errors

* * Added security considerations
* Rationale wording
* Link to EIP-5218
* Moved abstract functions to spec descriptions

* Reference implementation section

* shorten abstract

* fix link

* link fix

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Fix wording

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* wording

* move rationale up

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5553.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* wording

* Update eip-5553.md

* Update eip-5553.md

* Update eip-5553.md

* Wording.

* Grammar fix in specification

* Code renames

SongRegistration -> MusicalIP
royaltyInterestTokens -> royaltyRightsTokens

* Fix grammar and spelling

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants