Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website: Add PWA #5619

Closed
wants to merge 5 commits into from
Closed

Website: Add PWA #5619

wants to merge 5 commits into from

Conversation

Pandapip1
Copy link
Member

Can remove the manifest stuff if you want, but the caching is important IMO.

@Pandapip1 Pandapip1 requested a review from eth-bot as a code owner September 7, 2022 21:15
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 7, 2022

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) _config.yml

classification
ambiguous
  • '_config.yml' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

(fail) _layouts/base.html

classification
ambiguous
  • '_layouts/base.html' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

(fail) _layouts/eip.html

classification
ambiguous
  • '_layouts/eip.html' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

(fail) manifest.json

classification
ambiguous
  • 'manifest.json' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

(fail) service-worker.js

classification
ambiguous
  • 'service-worker.js' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

@Pandapip1 Pandapip1 linked an issue Sep 8, 2022 that may be closed by this pull request
Make EIPs Website a PWA #5608
Closed
@Pandapip1 Pandapip1 mentioned this pull request Sep 21, 2022
Closed
9 tasks
xinbenlv
xinbenlv reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you actively pursuing this? If not consider change to Draft?

@Pandapip1
Copy link
Member Author

This is complete, just contentious.

@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Nov 27, 2022
@Pandapip1
Copy link
Member Author

Still works

@github-actions github-actions bot removed the w-stale Waiting on activity label Nov 28, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 12, 2022
@Pandapip1
Copy link
Member Author

Still works

@github-actions github-actions bot removed the w-stale Waiting on activity label Dec 13, 2022
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Dec 28, 2022
@Pandapip1
Copy link
Member Author

Waiting on consensus.

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 5, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jan 19, 2023
@Pandapip1
Copy link
Member Author

Would still like to be able to access EIPs offline :)

@github-actions github-actions bot removed the w-stale Waiting on activity label Jan 20, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Feb 11, 2023
@Pandapip1
Copy link
Member Author

Dismissing stale bot.

@github-actions github-actions bot removed the w-stale Waiting on activity label Feb 12, 2023
@Pandapip1
Copy link
Member Author

Superseded by #6518

@Pandapip1 Pandapip1 closed this Feb 19, 2023
@Pandapip1 Pandapip1 deleted the Pandapip1-pwa branch February 19, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@xinbenlv xinbenlv xinbenlv left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make EIPs Website a PWA
4 participants
@Pandapip1 @eth-bot @xinbenlv @SamWilsn