Add EIP-2294: Explicit bound to Chain ID size #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
|
A critical exception has occurred: |
github-actions
bot
removed
c-new
xinbenlv
changed the title
github-actions
bot
added
c-new
xinbenlv
changed the title
xinbenlv
commented
Sep 28, 2022
xinbenlv
commented
Sep 28, 2022
Pandapip1
changed the title
Pandapip1
reviewed
Oct 3, 2022
github-actions
bot
added
s-review
Pandapip1
suggested changes
Oct 6, 2022
fubuloubu
previously approved these changes
Oct 6, 2022
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
github-actions
bot
added
s-draft
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
|
@Pandapip1 thanks for the feedback, I updated the draft. I feel the time sensitivity to publish this draft because of emerging expanded usage of chainId, e.g. the implementers and adopters of which was due to increasing dependency on EIP-712 and EIP-1271 that depend on eip-1344 |
xinbenlv
commented
Oct 6, 2022
|
Waiting for one of @axic @fubuloubu |
fubuloubu
approved these changes
Oct 6, 2022
Pandapip1
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
@fubuloubu apparently approved this in a private channel.
EDIT: Never mind, @fubuloubu approved this directly on the PR.
eth-bot
approved these changes
Oct 6, 2022
|
I added a relevant implementation detail that makes the stated limit for the value problematic in practical usage for wallets like metamask, see #2294 (comment) |
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* init chainidsize EIP pr * Recover the content from ethereum#2294 * EIP formating * EIP formatting * Update authost list and add credt * Move to Review * Update EIPS/eip-2294.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-2294.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-2294.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-2294.md * Update eip-2294.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
|
This EIP has been marked stagnant by the bot, does anyone know the status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resume the pursuit of #2294 for specifying the chain id size.