Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5679 Add Ref Impl #5739

Merged
merged 15 commits into from
Oct 2, 2022
Merged

Update EIP-5679 Add Ref Impl #5739

merged 15 commits into from
Oct 2, 2022

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Oct 2, 2022

Add mentioning of ref impl

See deployment on https://goerli.etherscan.io/address/0x672cf368Bf6c80517B43A83dD06A4041d7eD6C5E#code
Due to some link policy enforcement practice that I am personally still protesting #5597, I will leave out the etherscan link from this PR and follow up.

@xinbenlv xinbenlv requested a review from eth-bot as a code owner October 2, 2022 20:59
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Oct 2, 2022
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 2, 2022

All tests passed; auto-merging...

(pass) eip-5679.md

classification
updateEIP
  • passed!

@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review and removed c-new Creates a brand new proposal s-draft This EIP is a Draft labels Oct 2, 2022
@eth-bot eth-bot enabled auto-merge (squash) October 2, 2022 21:02
eth-bot
eth-bot previously approved these changes Oct 2, 2022
auto-merge was automatically disabled October 2, 2022 21:02

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) October 2, 2022 21:03
eth-bot
eth-bot previously approved these changes Oct 2, 2022
auto-merge was automatically disabled October 2, 2022 21:04

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) October 2, 2022 21:05
@eth-bot eth-bot merged commit 8d3298e into ethereum:master Oct 2, 2022
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* init

* Update ERC number

* Add content

* Add discussion-to

* Add ERC-165 identifiers

* Change public to external

* Update with batch and safe methods and add rationale.

* Fix format

* Fix EIPW errors

* Add mentioning of EIP-777

* Add refimpl for Ext20

* Fix

* update

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants