-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5679 Add Ref Impl #5739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
Creates a brand new proposal
s-draft
This EIP is a Draft
t-erc
labels
Oct 2, 2022
All tests passed; auto-merging...(pass) eip-5679.md
|
github-actions
bot
added
c-update
Modifies an existing proposal
s-review
This EIP is in Review
and removed
c-new
Creates a brand new proposal
s-draft
This EIP is a Draft
labels
Oct 2, 2022
eth-bot
previously approved these changes
Oct 2, 2022
auto-merge was automatically disabled
October 2, 2022 21:02
Head branch was pushed to by a user without write access
eth-bot
previously approved these changes
Oct 2, 2022
auto-merge was automatically disabled
October 2, 2022 21:04
Head branch was pushed to by a user without write access
eth-bot
approved these changes
Oct 2, 2022
nachomazzara
pushed a commit
to nachomazzara/EIPs
that referenced
this pull request
Jan 13, 2023
* init * Update ERC number * Add content * Add discussion-to * Add ERC-165 identifiers * Change public to external * Update with batch and safe methods and add rationale. * Fix format * Fix EIPW errors * Add mentioning of EIP-777 * Add refimpl for Ext20 * Fix * update * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mentioning of ref impl
See deployment on https://goerli.etherscan.io/address/0x672cf368Bf6c80517B43A83dD06A4041d7eD6C5E#code
Due to some link policy enforcement practice that I am personally still protesting #5597, I will leave out the etherscan link from this PR and follow up.