-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-4895: CL-EL withdrawals harmonization: using units of Gwei #6325
Conversation
A critical exception has occurred: |
The commit 41224ef (as a parent of 4a3fd72) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good other than the lint error
Updates the EL block hash computation for pytests to match latest spec. Notably, use `Gwei` for `Withdrawal` amount consistently. Also fix `excess_data_gas` not being correctly accounted for. ethereum/execution-apis#354 ethereum/EIPs#6325
09e26fe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Following discussion from here ethereum/pm#702, protocol devs want to explore harmonization in the withdrawals format from CL to EL.
This PR updates EIP-4895 with the first part of this change to use the same units (
Gwei
) for theamount
in each withdrawal.