Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4895: CL-EL withdrawals harmonization: using units of Gwei #6325

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

ralexstokes
Copy link
Member

Following discussion from here ethereum/pm#702, protocol devs want to explore harmonization in the withdrawals format from CL to EL.

This PR updates EIP-4895 with the first part of this change to use the same units (Gwei) for the amount in each withdrawal.

@eth-bot
Copy link
Collaborator

eth-bot commented Jan 12, 2023

A critical exception has occurred:
Message: pr 6325 is already merged; quitting
(cc @alita-moore, @mryalamanchi)

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 12, 2023
EIPS/eip-4895.md Outdated Show resolved Hide resolved
@github-actions
Copy link

The commit 41224ef (as a parent of 4a3fd72) contains errors.
Please inspect the Run Summary for details.

yperbasis
yperbasis previously approved these changes Jan 13, 2023
djrtwo
djrtwo previously approved these changes Jan 13, 2023
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good other than the lint error

etan-status
etan-status previously approved these changes Jan 14, 2023
etan-status added a commit to etan-status/consensus-specs that referenced this pull request Jan 15, 2023
Updates the EL block hash computation for pytests to match latest spec.
Notably, use `Gwei` for `Withdrawal` amount consistently.
Also fix `excess_data_gas` not being correctly accounted for.

ethereum/execution-apis#354
ethereum/EIPs#6325
@ralexstokes ralexstokes marked this pull request as ready for review January 16, 2023 18:07
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 16, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eth-bot eth-bot enabled auto-merge (squash) January 16, 2023 18:17
@eth-bot eth-bot merged commit b56a299 into ethereum:master Jan 16, 2023
yperbasis added a commit to erigontech/erigon that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants