-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5192: Change name to "Lockable tokens" #6330
Conversation
When this standard was created, the term "Soulbound tokens" was cool and new. Many people understood that a Soulbound token is "bound to a soul" and so it is a permanently locked token of an account. But since then, it has become clear that a Soulbound token is an umbrella term for all kinds of tokens that break conventional norms around private property assumptions. And besides, EIP-5192 implements dynamic locking of a token. So "Lockable Tokens" is a much better term for this specification and also for developers arriving at it in the future. I'm hence asking the EIP editors to make an exception regarding changing the contents of this EIP. The interface has not changed. Developers can still rely on using this token standard. The only change is an improvement in terms of accuracy in identifying what it is: A lockable token.
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) eip-5192.md
|
Good move. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in two minds about this.
- The correct way to refer to an EIP outside of the EIPs repository is
[EIP-X](https://eips.ethereum.org/EIPS/eip-x)
. As such, changing a name shouldn't cause any issues, and so in this regard I am inclined to approve this. - The name is not part of a normative section, and although this does change the Specification section, it is a minor wording change. In this regard, I am again inclined to approve this.
- I recognize many people don't follow the official recommendation in 1, and that the citation itself will change. In that regard, I am not inclined to approve this.
@SamWilsn what do you think
It makes sense. Still, calling the EIP with a strong reference to soulbound tokens, while that is just a specific use case, seems misleading to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title shouldn't be changed. I think that the rest is fine.
The criteria for updating a final EIP:
Even though the currently accepted definition of soulbound doesn't match exactly what this proposal provides, I don't think this qualifies as an errata or clarification. |
That'd make it quite confusing IMO. If we didn't change the title but referenced SBTs as "lockable tokens" internally. I think it should either be decided that this patch is 100% taken or 100% declined (which is both fine with me).
This is my view as well.
To be fair, a citation always has a date attached to it, so before date X you'd cite it as "Minimal Soulbound tokens" and after the date you cite it as "Lockable tokens." I see no issues with that. |
People now generally take Vitalik et al.'s paper as the canonical definition for SBTs and so when they see this specification many are usually confused. I think it's a mistake we've called it "Minimum Soulbound Tokens." |
Btw. I think it's problematic that there is another proposal called "Lockable ...": https://eips.ethereum.org/EIPS/eip-5058 |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment. |
When this standard was created, the term "Soulbound tokens" was cool and new. Many people understood that a Soulbound token is "bound to a soul," and so it is a permanently locked token of an account. But since then, it has become clear that a Soulbound token is an umbrella term for all kinds of tokens that break conventional norms around private property assumptions. And besides, EIP-5192 implements dynamic locking of a token. So "Lockable Tokens" is a much better term for this specification and also for developers arriving at it in the future.
I'm hence asking the EIP editors to make an exception regarding changing the contents of this EIP. The interface has not changed. Developers can still rely on using this token standard. The only change is an improvement in terms of accuracy in identifying what it is: A lockable token.