-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-210: Add BLOCKHASH contract tests #641
Conversation
3311515
to
1761460
Compare
When I tried to follow the commands, I saw
with more similar errors. |
This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:
If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR. In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks. Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:
|
Thank you for writing these. Do they really belong in the EIPs repo, though? |
Not sure, can be moved to its own repo. This is still work in progress. I need unit tests to be able to optimize the contract source code. |
@chfast are you still pursuing this? Would need to be rebased/merged onto master first. |
There were some voices not to keep the test cases in the EIP repo. I'm closing this. |
I started writing tests for BLOCKHASH contract using pyethereum and py.test.