Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself to EIP-1 list #6477

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Add myself to EIP-1 list #6477

merged 1 commit into from
Feb 9, 2023

Conversation

xinbenlv
Copy link
Contributor

@xinbenlv xinbenlv commented Feb 9, 2023

A follow-up of #5703

@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Feb 9, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 9, 2023

All reviewers have approved. Auto merging...

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

The commit b305a3c (as a parent of 742663a) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023
Copy link
Contributor

@gcolvin gcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

@xinbenlv
Copy link
Contributor Author

xinbenlv commented Feb 9, 2023

@Pandapip1 @SamWilsn thx! By the way, I encountered a mdlint error, but seems special, in the context it's a demonstration of rendering, could you help advice how to fix this mdlint error?

@eth-bot eth-bot enabled auto-merge (squash) February 9, 2023 18:11
@eth-bot eth-bot merged commit 78ec759 into ethereum:master Feb 9, 2023
@SamWilsn
Copy link
Contributor

SamWilsn commented Feb 9, 2023

could you help advice how to fix this mdlint error?

We should turn off that error. I think it's the only way to get a code block to appear inside the footnote list.

iseriohn pushed a commit to iseriohn/EIP-NFT-Rights-Management that referenced this pull request Feb 16, 2023
fulldecent pushed a commit to fulldecent/EIPs that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal t-process w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants