Add EIP-223: Token standard with event handling implementation #6485

Dexaran · 2023-02-09T21:55:06Z

title: Token Standard
description: ERC223 token implementing a communication model for interaction between contracts
author: <Dexaran (@Dexaran) dexaran@ethereumclassic.org
discussions-to: #223
status: Draft
type: Standards Track
category: ERC
created: <2017-05-03>

eth-bot · 2023-02-09T21:55:38Z

All reviewers have approved. Auto merging...

Dexaran · 2023-02-09T23:42:07Z

Finally. I thought I will never defeat your bots.

btw the current state of EIP20 does not match your requirements. Most importantly it contains the prohibited word "standard" in its title. And now it will look like ERC20 is the only "standard" on Ethereum and everything else is non-standard.

SamWilsn · 2023-02-10T02:58:47Z

Finally. I thought I will never defeat your bots.

Great! I hope the error messages were helpful, and if not, I'd love your feedback.

btw the current state of EIP20 does not match your requirements. Most importantly it contains the prohibited word "standard" in its title. And now it will look like ERC20 is the only "standard" on Ethereum and everything else is non-standard.

Yeah, that's an unfortunate side effect of treating "final" EIPs as nearly immutable. It's also a great example of why we prohibit "standard" in newer EIPs 🤣

SamWilsn · 2023-02-10T03:00:34Z

Ah, yeah, I just fixed incorrect line numbers bug. 🤞 I'll be deploying it shortly.

EIPS/eip-223.md

SamWilsn · 2023-02-10T03:04:12Z

EIPS/eip-223.md

@@ -0,0 +1,389 @@
+---
+eip: 223


Note to other editors: this eip is resurrecting #223

EIPS/eip-223.md

Commited readability improvements as suggested by the EIP editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Pandapip1 · 2023-03-05T13:27:08Z

EIPS/eip-223.md

+- [ERC-20](./eip-20.md) deposit: `approve` ~53K gas, `transferFrom` ~80K gas
+
+- ERC-223 deposit: `transfer` and handling on the receivers side ~46K gas


How does the deposit + call use less gas than an approve? I feel like this gas usage might be outdated

I have performed this tests https://github.com/Dexaran/Token_Deposits_GAS_testing using REMIX, solidity 0.8.19, optimization 200 runs

Updated the values:

approve >> 46K

deposit with transferFrom >> 75K

ERC223 deposit via transfer >> 53K

Your transferFrom function is very unoptimized, with 7 total internal contract calls from the initial transferFrom, most of them with three parameters (two 20-byte addresses and a 64-byte unsigned integer). Your ERC-223 contract has two, which both only take a single 20-byte parameter. This skews the results a lot.

EIPS/eip-223.md

Pandapip1 · 2023-03-05T13:30:00Z

EIPS/eip-223.md

+
+NOTE: A possible way to check whether the `_to` is a contract or an address is to assemble the code of `_to`. If there is no code in `_to`, then this is an externally owned address, otherwise it's a contract.
+
+### Contract that is intended to receive [ERC-223](./eip-223.md) tokens


@SamWilsn have we decided to allow self-references?

Also, I feel like we should ignore EIP linking rules for section titles.

In my opinion allowing self-references in EIPs would improve readability.

Imagine that we will have to compare one token (ERC-A) to three others (ERC-B, ERC-C, ERC-D).

We need to say that ERC-A is faster than ERC-B, more secure than ERC-C but cuter than ERC-D. At the same time it's cheaper than ERC-B, more expensive than ERC-C and still cuter than ERC-D.

With self-referencing:

"ERC-A is faster than ERC-B, more secure than ERC-C and cuter than ERC-D. ERC-A is cheaper than ERC-B, ERC-A is more expensive than ERC-C. ERC-A is still cuter than ERC-D."

Without self-referencing:

"The proposed token is faster than ERC-B, more secure than ERC-C and cuter than ERC-D. This token is cheaper than ERC-B, this token is more expensive than ERC-C. This token is still cuter than ERC-D."

Comparisons of ERCs/EIPs would be more readable if ALL EIPs (including the one being proposed) would be in the same format.

<disclaimer: English is not my native language so if anything is improperly phrased thats why>

"The proposed token is faster than ERC-B, more secure than ERC-C and cuter than ERC-D. This token is cheaper than ERC-B, this token is more expensive than ERC-C. This token is still cuter than ERC-D."

Self-references would be replaced with "this EIP" or "this ERC." Basically, it means that the reader doesn't need to remember what the current EIP's number is while they read the EIP. So this would become:

This ERC is faster than ERC-B, more secure than ERC-C and cuter than ERC-D. While this ERC is cheaper than ERC-B, it is more expensive than ERC-C. This ERC is still cuter than ERC-D."

Nonetheless, I definitely don't think this rule needs to be applied to section titles, as I feel that "this E[IP/RC]" would be cumbersome there. This comment was just to notify Sam about some eipw changes I would like.

EIPS/eip-223.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Pandapip1

I think this is good now.

…eum#6485) * Add EIP 223: Token standard with event handling implementation * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update EIPS/eip-223.md Commited readability improvements as suggested by the EIP editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Commited readability improvements as suggested by the EIP editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Readability improvements as suggested by the EIP editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Replaced `constant` function definitions with `view` to match modern Solidity * Update EIPS/eip-223.md Commited readability improvements as suggested by the EIPs editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Commited changes as suggested by the EIPs editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Adding a license. Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-223.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * re-added email * Update EIPS/eip-223.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Manually committing formatting change Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Fix formatting stuff Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Fix author list * Fix more formatting that Sam missed * Update EIPS/eip-223.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update eip-223.md * Update the code of Transfer(...) event * Fix function signature * Moved the tokenReceived() paragraph directly below transfer() deifnition * Backwards compatibility considerations * Update eip-223.md * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * Update EIPS/eip-223.md Co-authored-by: Gavin John <gavinnjohn@gmail.com> * update GAS tested values * updated the value of transferFrom GAS cost * Apply suggestions from code review * Move receiver to bottom * Remove old function * Lint --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Add EIP 223: Token standard with event handling implementation

b32a8a2

Dexaran requested a review from eth-bot as a code owner February 9, 2023 21:55

github-actions bot added c-new Creates a brand new proposal s-review This EIP is in Review t-erc labels Feb 9, 2023

github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023

Dexaran added 5 commits February 10, 2023 02:37

Update eip-223.md

09f3879

Update eip-223.md

4c6e49d

Update eip-223.md

337c7a0

Update eip-223.md

f3563ba

Update eip-223.md

74493a4

github-actions bot removed the w-ci Waiting on CI to pass label Feb 9, 2023

Dexaran added 8 commits February 10, 2023 03:05

Update eip-223.md

b305a79

Update eip-223.md

4523668

Update eip-223.md

537c9c6

Update eip-223.md

2f4595f

Update eip-223.md

0bad3d8

Update eip-223.md

f13c699

Update eip-223.md

a3d05a5

Update eip-223.md

0c8db1b

github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2023

Dexaran added 2 commits February 10, 2023 03:28

Update eip-223.md

4ef1631

Update eip-223.md

b3f6e3c

github-actions bot removed the w-ci Waiting on CI to pass label Feb 9, 2023

SamWilsn reviewed Feb 10, 2023

View reviewed changes

Update EIPS/eip-223.md

f265fed

Commited readability improvements as suggested by the EIP editor Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

github-actions bot removed s-review This EIP is in Review w-ci Waiting on CI to pass labels Mar 4, 2023

Dexaran requested a review from Pandapip1 March 4, 2023 03:07

Pandapip1 suggested changes Mar 5, 2023

View reviewed changes

Dexaran and others added 14 commits March 6, 2023 03:19

Update EIPS/eip-223.md

52da79f

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

71ef953

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

936eca6

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

bbba42b

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

bd965a3

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

5bf8c06

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

5735aaa

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

Update EIPS/eip-223.md

ab5818b

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

update GAS tested values

ba4b2d1

updated the value of transferFrom GAS cost

98e74ca

Apply suggestions from code review

218324b

Move receiver to bottom

5b09164

Remove old function

419550a

Lint

1a74ba0

Pandapip1 approved these changes Mar 6, 2023

View reviewed changes

eth-bot enabled auto-merge (squash) March 6, 2023 13:11

eth-bot approved these changes Mar 6, 2023

View reviewed changes

eth-bot merged commit 5058c8a into ethereum:master Mar 6, 2023

Dexaran mentioned this pull request Mar 7, 2023

EIP submission process does not match EIP-1 #6632

Closed

Dexaran mentioned this pull request Jul 19, 2023

Incompatible Transfer event Dexaran/TokenStandardConverter#4

Closed

Dexaran mentioned this pull request Aug 9, 2023

Update EIP-223: Update eip-223.md #7466

Merged

Pandapip1 mentioned this pull request Oct 16, 2023

Update EIP-223: Remove standard function #7856

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP-223: Token standard with event handling implementation #6485

Add EIP-223: Token standard with event handling implementation #6485

Dexaran commented Feb 9, 2023 •

edited

Loading

eth-bot commented Feb 9, 2023 •

edited

Loading

Dexaran commented Feb 9, 2023

SamWilsn commented Feb 10, 2023

SamWilsn commented Feb 10, 2023 •

edited

Loading

SamWilsn Feb 10, 2023

Pandapip1 Mar 5, 2023

Dexaran Mar 5, 2023 •

edited

Loading

Pandapip1 Mar 6, 2023 •

edited

Loading

Pandapip1 Mar 5, 2023

Dexaran Mar 6, 2023 •

edited

Loading

Pandapip1 Mar 6, 2023 •

edited

Loading

Pandapip1 left a comment

		- [ERC-20](./eip-20.md) deposit: `approve` ~53K gas, `transferFrom` ~80K gas

		- ERC-223 deposit: `transfer` and handling on the receivers side ~46K gas


		NOTE: A possible way to check whether the `_to` is a contract or an address is to assemble the code of `_to`. If there is no code in `_to`, then this is an externally owned address, otherwise it's a contract.

		### Contract that is intended to receive [ERC-223](./eip-223.md) tokens

Add EIP-223: Token standard with event handling implementation #6485

Add EIP-223: Token standard with event handling implementation #6485

Conversation

Dexaran commented Feb 9, 2023 • edited Loading

title: Token Standard description: ERC223 token implementing a communication model for interaction between contracts author: <Dexaran (@Dexaran) dexaran@ethereumclassic.org discussions-to: #223 status: Draft type: Standards Track category: ERC created: <2017-05-03>

eth-bot commented Feb 9, 2023 • edited Loading

Dexaran commented Feb 9, 2023

SamWilsn commented Feb 10, 2023

SamWilsn commented Feb 10, 2023 • edited Loading

SamWilsn Feb 10, 2023

Choose a reason for hiding this comment

Pandapip1 Mar 5, 2023

Choose a reason for hiding this comment

Dexaran Mar 5, 2023 • edited Loading

Choose a reason for hiding this comment

Pandapip1 Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

Pandapip1 Mar 5, 2023

Choose a reason for hiding this comment

Dexaran Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

Pandapip1 Mar 6, 2023 • edited Loading

Choose a reason for hiding this comment

Pandapip1 left a comment

Choose a reason for hiding this comment

Dexaran commented Feb 9, 2023 •

edited

Loading

title: Token Standard
description: ERC223 token implementing a communication model for interaction between contracts
author: <Dexaran (@Dexaran) dexaran@ethereumclassic.org
discussions-to: #223
status: Draft
type: Standards Track
category: ERC
created: <2017-05-03>

eth-bot commented Feb 9, 2023 •

edited

Loading

SamWilsn commented Feb 10, 2023 •

edited

Loading

Dexaran Mar 5, 2023 •

edited

Loading

Pandapip1 Mar 6, 2023 •

edited

Loading

Dexaran Mar 6, 2023 •

edited

Loading

Pandapip1 Mar 6, 2023 •

edited

Loading