Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-721: Spell collectible consistently #6527

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

christopheradams
Copy link
Contributor

Change the spelling of "collectable" to "collectible", to match the spelling in the rest of this and all other EIPs.

This is consistent with definitions that differentiate between items to be collected (like "collectable payments") and items of value worth collecting (like "collectible cards"). The latter is the intended meaning of NFTs.

@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-erc labels Feb 20, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 20, 2023

File EIPS/eip-721.md

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 20, 2023
@fulldecent
Copy link
Contributor

Cool, thank you

EIPS/eip-721.md Show resolved Hide resolved
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 12, 2023
@fulldecent
Copy link
Contributor

Thank you for sharing. The meaning and intent of the EIP is clear, but the language use appears to be incorrect, I appreciate you bringing this up.

Perhaps the Google Ngram database can be helpful in studying how English is used. And that source supports the correct spelling as collectible cards.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Aug 14, 2023
@Pandapip1 Pandapip1 dismissed their stale review August 14, 2023 10:01

I won't block this, but I am not convinced enough to approve it

@github-actions github-actions bot removed the w-stale Waiting on activity label Aug 15, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Aug 29, 2023
@fulldecent
Copy link
Contributor

Hi @christopheradams can you please rebase your improvement here?

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 1, 2023
@christopheradams
Copy link
Contributor Author

Hi @christopheradams can you please rebase your improvement here?

Ok, I've rebased my improvement on the master branch.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

The commit fdece81 (as a parent of 0da299e) contains errors.
Please inspect the Run Summary for details.

@fulldecent
Copy link
Contributor

Thank you. As a pure play, I'm addressing some of the linter errors here: #7550

If I can merge that and a couple others the hopefully your PR can be merged more smoothly.

@SamWilsn SamWilsn merged commit df1192b into ethereum:master Sep 13, 2023
8 of 9 checks passed
@christopheradams
Copy link
Contributor Author

I'm honored.

streamnft-tech pushed a commit to streamnft-tech/EIPs that referenced this pull request Oct 27, 2023
RaphaelHardFork pushed a commit to RaphaelHardFork/EIPs that referenced this pull request Jan 30, 2024
just-a-node pushed a commit to connext/EIPs that referenced this pull request Feb 17, 2024
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-erc w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants