-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-721: Spell collectible consistently #6527
Conversation
File
|
Cool, thank you |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Thank you for sharing. The meaning and intent of the EIP is clear, but the language use appears to be incorrect, I appreciate you bringing this up. Perhaps the Google Ngram database can be helpful in studying how English is used. And that source supports the correct spelling as |
I won't block this, but I am not convinced enough to approve it
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
Hi @christopheradams can you please rebase your improvement here? |
41c9e37
to
fdece81
Compare
Ok, I've rebased my improvement on the master branch. |
The commit fdece81 (as a parent of 0da299e) contains errors. |
Thank you. As a pure play, I'm addressing some of the linter errors here: #7550 If I can merge that and a couple others the hopefully your PR can be merged more smoothly. |
I'm honored. |
Change the spelling of "collectable" to "collectible", to match the spelling in the rest of this and all other EIPs.
This is consistent with definitions that differentiate between items to be collected (like "collectable payments") and items of value worth collecting (like "collectible cards"). The latter is the intended meaning of NFTs.