Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Modular Smart Contract Accounts and Plugins #6900

Merged

Conversation

adam-alchemy
Copy link
Contributor

This EIP proposes a standard for modular smart contract accounts and plugins, which allow for composable logic within smart contract accounts. This proposal is compliant with ERC-4337, and builds on the existing work from ERC-2535 when defining interfaces for updating and querying modular function implementations.

@adam-alchemy adam-alchemy requested a review from eth-bot as a code owner April 19, 2023 03:45
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Apr 19, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 19, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add EIP Modular Smart Contract Accounts and Plugins Add EIP: Modular Smart Contract Accounts and Plugins Apr 19, 2023
@eth-bot eth-bot added a-review Waiting on author to review e-consensus Waiting on editor consensus labels Apr 19, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 19, 2023
Comment on lines 15 to 16
This proposal standardizes smart contract accounts and account plugins, which are smart contract interfaces that allow for composable logic within smart contract accounts. This proposal is compliant with [ERC-4337](./eip-4337.md), and builds on the existing work from [ERC-2535](./eip-2535.md) when defining interfaces for updating and querying modular function implementations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to see a tiny description of how this modular approach works, compared to other modular standards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sentence:

This modular approach splits account functionality into three categories, delegates them to external contracts, and defines an expected execution flow from accounts.

EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved

`LibMyPlugin.sol`

```solidity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples like this generally should go in the reference implementation, especially if they aren't normative, but this is short so I'll leave it up to your discretion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will keep it in this section for now, but will possibly revise later. Thanks for mentioning.

EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
EIPS/eip-modular-smart-contract-accounts-and-plugins.md Outdated Show resolved Hide resolved
@eth-bot eth-bot changed the base branch from master to eipbot/6900 May 2, 2023 15:22
@eth-bot eth-bot changed the base branch from eipbot/6900 to master May 2, 2023 15:22
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels May 3, 2023
trinity-0111
trinity-0111 previously approved these changes May 3, 2023
@adam-alchemy adam-alchemy requested a review from SamWilsn May 3, 2023 17:40
@adam-alchemy adam-alchemy dismissed stale reviews from trinity-0111 and fangting-alchemy via 81ab422 May 4, 2023 16:52
@eth-bot eth-bot added the e-review Waiting on editor to review label May 4, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

The commit 5a0e9de (as a parent of 4376071) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 4, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 4, 2023
EIPS/eip-6900.md Outdated Show resolved Hide resolved
EIPS/eip-6900.md Outdated
---
eip: 6900
title: Modular Smart Contract Accounts and Plugins
description: An interface for modular smart contract accounts with plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description restates too much of the title. You also have several interfaces, not just one.

How about something like:

Suggested change
description: An interface for modular smart contract accounts with plugins.
description: Interfaces for composable plugins optionally supporting upgradability and introspection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "Interfaces for composable account plugins optionally supporting upgradability and introspection"

EIPS/eip-6900.md Outdated Show resolved Hide resolved
EIPS/eip-6900.md Outdated Show resolved Hide resolved
EIPS/eip-6900.md Outdated Show resolved Hide resolved
EIPS/eip-6900.md Outdated Show resolved Hide resolved
EIPS/eip-6900.md Outdated Show resolved Hide resolved
EIPS/eip-6900.md Outdated Show resolved Hide resolved
@eth-bot eth-bot enabled auto-merge (squash) May 5, 2023 03:11
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit c61199c into ethereum:master May 5, 2023
@xinbenlv
Copy link
Contributor

I think this is really an interesting EIP. @adam-alchemy , do you want to take 5-10min share about this EIP in our first AllERCDevs session so as to bring this to more people's attention?
Sign up agenda here ercref/AllERCDevs#1
And the time is May 16th Tuesday 4pm PT / 7pm ET / UTC2300

@adam-alchemy
Copy link
Contributor Author

Yes we'd be happy to @xinbenlv, thank you for the invitation. @jwindawi just submitted an agenda item request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants