Update EIP-4844: add data_gas_used to header
#7062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
eth-bot
changed the title
data_gas_used to headerdata_gas_used to header
|
note, just an idea, wanted to see what it actually looked like to do this |
|
I find this easier to understand. (...I've lost track of how many times I've gotten confused over parent vs current block for gathering appropriate data for blob pricing in the current spec.) Not sure how we trade that off against requiring another header field though. |
IMO there is very little difference between adding one additional header field vs. two. |
yperbasis
previously approved these changes
May 26, 2023
lightclient
force-pushed
the
add-data-gas-used
branch
from
972c95f
to
88b8355
Compare
This was referenced May 30, 2023
Closed
lightclient
force-pushed
the
add-data-gas-used
branch
from
88b8355
to
e8ae088
Compare
|
Had to rebase - changes should be the same though. |
lightclient
force-pushed
the
add-data-gas-used
branch
3 times, most recently
from
a13bda1
to
939170c
Compare
g11tech
reviewed
May 30, 2023
This was referenced May 30, 2023
g11tech
previously approved these changes
May 31, 2023
lightclient
force-pushed
the
add-data-gas-used
branch
from
939170c
to
5245d43
Compare
adietrichs
previously approved these changes
Jun 1, 2023
Co-authored-by: Ansgar Dietrichs <adietrichs@gmail.com>
|
applied suggestions from @adietrichs, going to undraft now |
eth-bot
approved these changes
Jun 1, 2023
Merged
7 tasks
AlexeyAkhunov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Jun 2, 2023
Implement ethereum/EIPs#7062 and ethereum/EIPs#7095. Pick up ledgerwatch/erigon-lib#1006.
20 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, EIP-4844 uses the
excess_data_gasfrom a block's parent header in order to determine the data gas price of transactions in the current block. This is a bit different than EIP-1559 which first ensures the header'sbase_feeis correctly derived from the parent header, then proceeds to use that value for further gas price calculation.tldr;
excess_data_gasis pricing for next block, whilebase_feeis pricing for current block -- this PR aligns them so that both represent pricing information for the current block