Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1153: EIP-1153 - Change TLOAD/TSTORE opcodes #7074

Merged
merged 3 commits into from
May 26, 2023

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented May 25, 2023

Restore the opcodes to 0x5c and 0x5d, as per execution layer meeting #162.

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Restore the opcodes to 0x5c and 0x5d, as per execution layer meeting ethereum#162.
@shemnon shemnon requested a review from eth-bot as a code owner May 25, 2023 22:30
@github-actions github-actions bot added c-update Modifies an existing proposal t-core labels May 25, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 25, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title EIP-1153 - Change TLOAD/TSTORE opcodes Update EIP-1153: EIP-1153 - Change TLOAD/TSTORE opcodes May 25, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label May 25, 2023
@github-actions
Copy link

The commit 3cc6c2f (as a parent of d7bcf8e) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 25, 2023
moodysalem
moodysalem previously approved these changes May 25, 2023
@eth-bot eth-bot enabled auto-merge (squash) May 25, 2023 23:37
eth-bot
eth-bot previously approved these changes May 25, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled May 26, 2023 16:18

Head branch was pushed to by a user without write access

@shemnon shemnon dismissed stale reviews from eth-bot and moodysalem via 6271447 May 26, 2023 16:18
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 26, 2023
@shemnon
Copy link
Contributor Author

shemnon commented May 26, 2023

@moodysalem gonna need another approval because validation errors blocked merging

@eth-bot eth-bot enabled auto-merge (squash) May 26, 2023 17:13
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants