Add EIP: Financial Bonds #7092

Edoumou · 2023-05-29T11:24:20Z

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

The PR edits only existing draft PRs.
The build passes.
Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
If matching on email address, the email address is the one publicly listed on your GitHub profile.

Add financial bonds draft

eth-bot · 2023-05-29T11:24:51Z

File `EIPS/eip-7092.md`

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

EIPS/eip-7092.md

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

EIPS/eip-7092.md

github-actions · 2023-07-25T12:06:07Z

The commit 62358ad (as a parent of a6d216a) contains errors.
Please inspect the Run Summary for details.

Edoumou · 2023-07-25T12:25:25Z

Hello @lightclient

I just added changes you requested. Can you review and approve them ?

lightclient

One last issue. All EIPs must be in the public domain.

assets/eip-7092/IERC7092.sol

assets/eip-7092/ERC7092.sol

assets/eip-7092/BondStorage.sol

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

Edoumou · 2023-07-25T13:14:41Z

One last issue. All EIPs must be in the public domain.

Hello @lightclient

I just updated the License from MIT to CC0-1.0

lightclient

Looks good, thanks!

@fosgate29

* Add financial bonds draft * Update eip-financial_bonds.md * Update and rename eip-financial_bonds.md to eip-7092.md * Add embedded options logic * Update eip-7092.md * Update eip-7092.md * change disapprove functions to decreaseAllowance functions * Update eip-7092.md * update to RECOMMENDED * change IERC to IERC7092 * change event Disapprove to AllowanceDecreased * Create ERC7092.sol in the assets folder * Move eip-7092 in EIPS folder * Rename eip-7092 to eip-7092.md * Create IERC7092.sol * Create BondStorage.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * updates ref * Update ref * remove md file in the EIP root * change disapprove to decreaseAllowance * Update eip-7092.md * Create CouponMath.sol * change EIP to EIP7092 in CouponMath.sol * Update BondStorage.sol * Update embedded options functions * Update ERC7092.sol * Update BondStorage.sol * Update contracts with embeded options * wip * fix a couple of typos As proposed by @fosgate29 * change transfers functions to return a boolean * change _transfer function to return a bioolean * implement a third level heading for bonds embedded options title * update specs * update motivation * update rational * update * Update eip-7092 * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * update rationale * return boolean for approve function * Update eip-7092.md * return boolean to approve and decrease allowance * Update ERC7092.sol * Update Rationale * Update * Update eip-7092 * Add optional key * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update ERC7092.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * add totalSupply and balanceOf in BondStorage * add totalSupply and balanceOf functions * add totalSupply and balanceOf functions * remove totalSupply and balanceOf in bondStorage - already defined in ERC contract * Update eip-7092.md * Update CouponMath.sol * update text: replace tracker by explorer * add link to etherscan * remove link: not supported * update the eip-7092 according to comments from @lightclient * keep backward compatibility as sub-sub-section for tests to pass * Update EIPS/eip-7092.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update eip-7092.md * UIpdarte the Backward Compatibility to appear as a section * Update assets/eip-7092/IERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/ERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/BondStorage.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update CouponMath.sol --------- Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

@fosgate29

* Add financial bonds draft * Update eip-financial_bonds.md * Update and rename eip-financial_bonds.md to eip-7092.md * Add embedded options logic * Update eip-7092.md * Update eip-7092.md * change disapprove functions to decreaseAllowance functions * Update eip-7092.md * update to RECOMMENDED * change IERC to IERC7092 * change event Disapprove to AllowanceDecreased * Create ERC7092.sol in the assets folder * Move eip-7092 in EIPS folder * Rename eip-7092 to eip-7092.md * Create IERC7092.sol * Create BondStorage.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * updates ref * Update ref * remove md file in the EIP root * change disapprove to decreaseAllowance * Update eip-7092.md * Create CouponMath.sol * change EIP to EIP7092 in CouponMath.sol * Update BondStorage.sol * Update embedded options functions * Update ERC7092.sol * Update BondStorage.sol * Update contracts with embeded options * wip * fix a couple of typos As proposed by @fosgate29 * change transfers functions to return a boolean * change _transfer function to return a bioolean * implement a third level heading for bonds embedded options title * update specs * update motivation * update rational * update * Update eip-7092 * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * update rationale * return boolean for approve function * Update eip-7092.md * return boolean to approve and decrease allowance * Update ERC7092.sol * Update Rationale * Update * Update eip-7092 * Add optional key * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update ERC7092.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * add totalSupply and balanceOf in BondStorage * add totalSupply and balanceOf functions * add totalSupply and balanceOf functions * remove totalSupply and balanceOf in bondStorage - already defined in ERC contract * Update eip-7092.md * Update CouponMath.sol * update text: replace tracker by explorer * add link to etherscan * remove link: not supported * update the eip-7092 according to comments from @lightclient * keep backward compatibility as sub-sub-section for tests to pass * Update EIPS/eip-7092.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update eip-7092.md * UIpdarte the Backward Compatibility to appear as a section * Update assets/eip-7092/IERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/ERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/BondStorage.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update CouponMath.sol --------- Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

@fosgate29

* Add financial bonds draft * Update eip-financial_bonds.md * Update and rename eip-financial_bonds.md to eip-7092.md * Add embedded options logic * Update eip-7092.md * Update eip-7092.md * change disapprove functions to decreaseAllowance functions * Update eip-7092.md * update to RECOMMENDED * change IERC to IERC7092 * change event Disapprove to AllowanceDecreased * Create ERC7092.sol in the assets folder * Move eip-7092 in EIPS folder * Rename eip-7092 to eip-7092.md * Create IERC7092.sol * Create BondStorage.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * updates ref * Update ref * remove md file in the EIP root * change disapprove to decreaseAllowance * Update eip-7092.md * Create CouponMath.sol * change EIP to EIP7092 in CouponMath.sol * Update BondStorage.sol * Update embedded options functions * Update ERC7092.sol * Update BondStorage.sol * Update contracts with embeded options * wip * fix a couple of typos As proposed by @fosgate29 * change transfers functions to return a boolean * change _transfer function to return a bioolean * implement a third level heading for bonds embedded options title * update specs * update motivation * update rational * update * Update eip-7092 * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * update rationale * return boolean for approve function * Update eip-7092.md * return boolean to approve and decrease allowance * Update ERC7092.sol * Update Rationale * Update * Update eip-7092 * Add optional key * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update ERC7092.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * add totalSupply and balanceOf in BondStorage * add totalSupply and balanceOf functions * add totalSupply and balanceOf functions * remove totalSupply and balanceOf in bondStorage - already defined in ERC contract * Update eip-7092.md * Update CouponMath.sol * update text: replace tracker by explorer * add link to etherscan * remove link: not supported * update the eip-7092 according to comments from @lightclient * keep backward compatibility as sub-sub-section for tests to pass * Update EIPS/eip-7092.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update eip-7092.md * UIpdarte the Backward Compatibility to appear as a section * Update assets/eip-7092/IERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/ERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/BondStorage.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update CouponMath.sol --------- Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

@fosgate29

* Add financial bonds draft * Update eip-financial_bonds.md * Update and rename eip-financial_bonds.md to eip-7092.md * Add embedded options logic * Update eip-7092.md * Update eip-7092.md * change disapprove functions to decreaseAllowance functions * Update eip-7092.md * update to RECOMMENDED * change IERC to IERC7092 * change event Disapprove to AllowanceDecreased * Create ERC7092.sol in the assets folder * Move eip-7092 in EIPS folder * Rename eip-7092 to eip-7092.md * Create IERC7092.sol * Create BondStorage.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * updates ref * Update ref * remove md file in the EIP root * change disapprove to decreaseAllowance * Update eip-7092.md * Create CouponMath.sol * change EIP to EIP7092 in CouponMath.sol * Update BondStorage.sol * Update embedded options functions * Update ERC7092.sol * Update BondStorage.sol * Update contracts with embeded options * wip * fix a couple of typos As proposed by @fosgate29 * change transfers functions to return a boolean * change _transfer function to return a bioolean * implement a third level heading for bonds embedded options title * update specs * update motivation * update rational * update * Update eip-7092 * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * update rationale * return boolean for approve function * Update eip-7092.md * return boolean to approve and decrease allowance * Update ERC7092.sol * Update Rationale * Update * Update eip-7092 * Add optional key * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * Update ERC7092.sol * Update eip-7092.md * Update eip-7092.md * Update eip-7092.md * add totalSupply and balanceOf in BondStorage * add totalSupply and balanceOf functions * add totalSupply and balanceOf functions * remove totalSupply and balanceOf in bondStorage - already defined in ERC contract * Update eip-7092.md * Update CouponMath.sol * update text: replace tracker by explorer * add link to etherscan * remove link: not supported * update the eip-7092 according to comments from @lightclient * keep backward compatibility as sub-sub-section for tests to pass * Update EIPS/eip-7092.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update eip-7092.md * UIpdarte the Backward Compatibility to appear as a section * Update assets/eip-7092/IERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/ERC7092.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update assets/eip-7092/BondStorage.sol Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update CouponMath.sol --------- Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

Edoumou added 3 commits May 28, 2023 21:37

Add financial bonds draft

8822539

Update eip-financial_bonds.md

1e35c33

Merge pull request #1 from Edoumou/Edoumou-financial-bonds

af2e228

Add financial bonds draft

Edoumou requested a review from eth-bot as a code owner May 29, 2023 11:24

github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels May 29, 2023

eth-bot added the e-consensus Waiting on editor consensus label May 29, 2023

Edoumou added 3 commits May 29, 2023 13:35

Update and rename eip-financial_bonds.md to eip-7092.md

d1771e5

Add embedded options logic

c03771c

Update eip-7092.md

bceaf4e

github-actions bot added the w-ci Waiting on CI to pass label May 29, 2023

Update eip-7092.md

0911029

github-actions bot removed the w-ci Waiting on CI to pass label May 29, 2023

Edoumou added 9 commits May 29, 2023 20:58

Merge branch 'master' into master

dfccd4f

change disapprove functions to decreaseAllowance functions

ded0567

Update eip-7092.md

f1aae56

update to RECOMMENDED

e344b7a

change IERC to IERC7092

3d14ede

Merge branch 'master' into master

080c40e

change event Disapprove to AllowanceDecreased

b850ad3

Create ERC7092.sol in the assets folder

289d3f6

Move eip-7092 in EIPS folder

19b3059

github-actions bot added the w-ci Waiting on CI to pass label May 30, 2023

Rename eip-7092 to eip-7092.md

7803f60

eth-bot added the e-review Waiting on editor to review label May 30, 2023

Edoumou added 2 commits May 30, 2023 18:13

Create IERC7092.sol

f9f9d82

Create BondStorage.sol

452ba91

github-actions bot removed the w-ci Waiting on CI to pass label May 30, 2023

Edoumou added 4 commits July 23, 2023 15:35

Update CouponMath.sol

af75721

update text: replace tracker by explorer

2e6418c

add link to etherscan

6250c34

remove link: not supported

54c6200

lightclient requested changes Jul 24, 2023

View reviewed changes

update the eip-7092 according to comments from @lightclient

aeb7991

github-actions bot added the w-ci Waiting on CI to pass label Jul 25, 2023

keep backward compatibility as sub-sub-section for tests to pass

5967954

github-actions bot removed the w-ci Waiting on CI to pass label Jul 25, 2023

Update EIPS/eip-7092.md

62358ad

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

lightclient reviewed Jul 25, 2023

View reviewed changes

EIPS/eip-7092.md Outdated Show resolved Hide resolved

github-actions bot added the w-ci Waiting on CI to pass label Jul 25, 2023

Update eip-7092.md

ca61a31

github-actions bot removed the w-ci Waiting on CI to pass label Jul 25, 2023

UIpdarte the Backward Compatibility to appear as a section

c18b8d6

Edoumou requested a review from lightclient July 25, 2023 12:22

lightclient reviewed Jul 25, 2023

View reviewed changes

assets/eip-7092/IERC7092.sol Outdated Show resolved Hide resolved

assets/eip-7092/ERC7092.sol Outdated Show resolved Hide resolved

assets/eip-7092/BondStorage.sol Outdated Show resolved Hide resolved

Edoumou and others added 4 commits July 25, 2023 15:09

Update assets/eip-7092/IERC7092.sol

053c391

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

Update assets/eip-7092/ERC7092.sol

b7e8fd0

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

Update assets/eip-7092/BondStorage.sol

420b0c8

Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

Update CouponMath.sol

0984d88

lightclient approved these changes Jul 25, 2023

View reviewed changes

lightclient merged commit b8c088d into ethereum:master Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EIP: Financial Bonds #7092

Add EIP: Financial Bonds #7092

Edoumou commented May 29, 2023

eth-bot commented May 29, 2023 •

edited

Loading

github-actions bot commented Jul 25, 2023

Edoumou commented Jul 25, 2023 •

edited

Loading

lightclient left a comment

Edoumou commented Jul 25, 2023 •

edited

Loading

lightclient left a comment

Add EIP: Financial Bonds #7092

Add EIP: Financial Bonds #7092

Conversation

Edoumou commented May 29, 2023

eth-bot commented May 29, 2023 • edited Loading

File EIPS/eip-7092.md

github-actions bot commented Jul 25, 2023

Edoumou commented Jul 25, 2023 • edited Loading

lightclient left a comment

Choose a reason for hiding this comment

Edoumou commented Jul 25, 2023 • edited Loading

lightclient left a comment

Choose a reason for hiding this comment

eth-bot commented May 29, 2023 •

edited

Loading

File `EIPS/eip-7092.md`

Edoumou commented Jul 25, 2023 •

edited

Loading

Edoumou commented Jul 25, 2023 •

edited

Loading