Update EIP-6492: Move to Last Call #7181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ivshti
commented
Jun 15, 2023
•
Ivshti
commented
- No further usable feedback has been provided since May (see here)
- It has been implemented in signature-validator, SIWE and others
…ually Deployed Contracts * Error fixes * Readability improvements * Better definitions
* Moved counterfactual check to the beginning
* Add a note about key invalidation
* Propose a validation implementation that does not require pre-deploying singletons
* Consistency in using verification/validation * Suggest a library to use
* Specify off-chain usage * Change example contract to something a bit more compiler optimizable
* Fix contract issue
* Add on-chain validation singleton
* Add on-chain validation singleton
* Change status to review
* Remove ERC-4337 link so that the EIP can be considered stable
* Add Agustin Aguilar (@Agusx1211)
* Reduce ambiguity
* Reduce ambiguity
|
✅ All reviewers have approved. |
|
closing in order to consider #7284 |
|
oops, last call is still an ok status to make that change, hence reopening |
|
@axic @SamWilsn @Pandapip1 @xinbenlv would be great to get this merged please 🙏 |
xinbenlv
approved these changes
Aug 4, 2023
eth-bot
approved these changes
Aug 4, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.