Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Add xinbenlv (myself) to governance group #7745

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

xinbenlv
Copy link
Contributor

Add xinbenlv (myself) to governance group

@xinbenlv xinbenlv requested a review from eth-bot as a code owner September 20, 2023 20:46
@eth-bot
Copy link
Collaborator

eth-bot commented Sep 20, 2023

File config/eip-editors.yml

Requires 1 more reviewers from @axic, @lightclient

@eth-bot eth-bot changed the title Add xinbenlv (myself) to governance group Config: Add xinbenlv (myself) to governance group Sep 20, 2023
@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Sep 20, 2023
Pandapip1
Pandapip1 previously approved these changes Sep 20, 2023
SamWilsn
SamWilsn previously approved these changes Sep 20, 2023
g11tech
g11tech previously approved these changes Sep 21, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lightclient
Copy link
Member

What does this mean practically? What does the governance group do?

@SamWilsn
Copy link
Contributor

@xinbenlv has been ratified as a full Editor in https://github.com/ethereum-cat-herders/EIPIP/issues/286, so he's free to choose whatever categories he wants to review.

@SamWilsn SamWilsn dismissed stale reviews from g11tech, Pandapip1, and themself via bf4f56e November 21, 2023 03:57
@SamWilsn SamWilsn merged commit 01ba9da into ethereum:master Nov 21, 2023
8 of 10 checks passed
Copy link

The commit bf4f56e (as a parent of b1ebf6e) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 21, 2023
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
Update eip-editors.yml

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
Update eip-editors.yml

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e-consensus Waiting on editor consensus w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants