Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: minor clean-up #7997

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 30, 2023

Clean up the leftover of #6985

  1. Remove the unused LIMIT_BLOBS_PER_TX definition
  2. Since SignedBlobTransaction has been deleted, use a pseudo-code helper get_tx_type for checking tx type

/cc @lightclient

@hwwhww hwwhww requested a review from eth-bot as a code owner November 30, 2023 13:53
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Nov 30, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 30, 2023

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Nov 30, 2023
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eth-bot eth-bot enabled auto-merge (squash) November 30, 2023 14:16
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 14d6cf4 into ethereum:master Nov 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants