-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Hardfork Meta Backfill - Berlin to Shapella #8005
Conversation
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
✅ All reviewers have approved. |
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
EIPS/eip-meta-hardfork-meta.md
Outdated
@@ -0,0 +1,91 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- | |
--- | |
eip: 7568 |
Assigning next sequential EIP/ERC/RIP number.
Numbering changed to sequential from 7500 and is no longer the PR number.
Please also update the filename.
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
Btw I kind of liked how all the eips were explicitly listed in the dencun meta eip. Any thoughts on doing that for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@lightclient interesting idea! Some of the CL upgrades don't have EIPs, but do you think it's worth doing for everything that does? |
I can go either way. I suppose the execution-specs has the list to all the EIPs anyways. I'll leave it up to you to decide and then I will merge. |
Getting an error on the discussion-to link, thus sharing thoughts here.
For Berlin we can perhaps resurrect EIP-2070.
I'd like to see EIP-2387 in "requires" to provide the information or prior upgrade that is needed to get to the following network upgrades. |
Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
The commit 0862c0d (as a parent of 58187a7) contains errors. |
Thanks for your comments, @poojaranjan @lightclient! My last commit addresses them as follows:
Instead of listing everything, I made it explicit that the linked specs themselves link to the specific changes in forks. Didn't use "EIPs" because there are none one the first CL forks 😅 !
Fixed the link!
Good catch! I've opened #8028 to move 2070 to
I agree it's a bit unusual for these to be included even though they are not Core EIPs themselves. I included them because they both significantly alter the behavior of the network (or describe that alteration), and I'd rather lean towards having them and providing readers a full picture vs. potentially omitting something important. Similarly, 2982 is not a Core EIP but provides important context. |
Thanks for addressing earlier comments, @timbeiko. Even though this EIP includes missing Meta EIP history, IMHO, it should include EIP-2387: Hardfork Meta: Muir Glacier in "Requires" to include upgrade Meta before Berlin upgrade. Including prior upgrade Meta EIP in "Requires" had been in practice (eg EIP-1679 is added to EIP-2387) to connect the dots. It will be nice to see it continued. |
status: Draft | ||
type: Meta | ||
created: 2023-12-01 | ||
requires: 2070, 2387, 2982, 6122, 6953 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poojaranjan oops, didn't mention it, but it does!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
On ACDC#123 we agreed to bring back Hardfork Meta EIPs for Dencun. This EIP "backfills" the forks for which we did not have Meta EIPs by linking out to specifications for each upgrade. Having this merged before the Dencun Hardfork Meta will keep the numbering of Hardfork Meta EIPs chronically aligned with mainnet deployment times.