Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7569: Add Testnet times #8051

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

timbeiko
Copy link
Contributor

On ACDE#177 we agreed to fork Goerli at epoch 231680, then to fork Sepolia on Jan 31st, 2024 and finally Holesky on Feb 7th. This PR adds the Goerli epoch and timestamps, and proposes specific ones for the two other testnets.

All times taken from https://slots.symphonious.net

Associated EL specs PR: ethereum/execution-specs#860

Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-meta labels Dec 21, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 21, 2023

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Add Testnet times Update EIP-7569: Add Testnet times Dec 21, 2023
@eth-bot eth-bot enabled auto-merge (squash) December 21, 2023 15:30
eth-bot
eth-bot previously approved these changes Dec 21, 2023
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Signed-off-by: Tim Beiko <9390255+timbeiko@users.noreply.github.com>
auto-merge was automatically disabled December 21, 2023 15:31

Head branch was pushed to by a user without write access

@eth-bot eth-bot enabled auto-merge (squash) December 21, 2023 15:32
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@abcoathup abcoathup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, double checked https://slots.symphonious.net/
Timings look good for Melbourne.

@eth-bot eth-bot enabled auto-merge (squash) January 8, 2024 13:57
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit dfee781 into ethereum:master Jan 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants