Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5792: Add showCallsStatus #8392

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

lukasrosario
Copy link
Contributor

  • add back wallet_showCallsStatus. this is a method that requests a wallet shows information about a call bundle. this was part of the original EIP-5792.
  • added semicolons throughout ts
  • add an address param to wallet_getCapabilities. capabilities can differ per address. also noted that apps should have an already-approved connection to this provided address.

@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-interface labels Apr 5, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 5, 2024

✅ All reviewers have approved.

@jxom jxom mentioned this pull request Apr 6, 2024
EIPS/eip-5792.md Show resolved Hide resolved
@lukasrosario lukasrosario marked this pull request as ready for review April 7, 2024 19:59
@lukasrosario lukasrosario requested a review from eth-bot as a code owner April 7, 2024 19:59
@lukasrosario lukasrosario reopened this Apr 7, 2024
@eth-bot eth-bot enabled auto-merge (squash) April 7, 2024 20:22
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 33dc682 into ethereum:master Apr 7, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants