-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-6110: put deposits into request struct #8440
Conversation
File
|
The commit bc1ca6e (as a parent of 1796bc6) contains errors. |
RLP(amount), | ||
RLP(signature), | ||
RLP(index) | ||
encoded_deposit = 0x00 ++ rlp([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with applying general request format to deposits is that CL and EL need to parse deposit data from their block structures, and each layer use own encoding for the same data (SSZ vs RLP).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's unclear, but this is only the encoding for the EL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarification! Now it makes more sense
This is pending on #8432.Adds deposits to the EIP-7685 requests list in the execution layer block.