Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-6110: put deposits into request struct #8440

Closed
wants to merge 1 commit into from

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Apr 15, 2024

This is pending on #8432.

Adds deposits to the EIP-7685 requests list in the execution layer block.

@lightclient lightclient requested a review from eth-bot as a code owner April 15, 2024 19:55
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Apr 15, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 15, 2024

File EIPS/eip-6110.md

Requires 1 more reviewers from @djrtwo, @mkalinin, @petertdavies

@eth-bot eth-bot added the a-review Waiting on author to review label Apr 15, 2024
@eth-bot eth-bot changed the title 6110: put deposits into request struct Update EIP-6110: put deposits into request struct Apr 15, 2024
Copy link

The commit bc1ca6e (as a parent of 1796bc6) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 15, 2024
RLP(amount),
RLP(signature),
RLP(index)
encoded_deposit = 0x00 ++ rlp([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with applying general request format to deposits is that CL and EL need to parse deposit data from their block structures, and each layer use own encoding for the same data (SSZ vs RLP).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's unclear, but this is only the encoding for the EL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification! Now it makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants