Add EIP: ETH transfers emit a log

[vbuterin]

All ETH-transferring calls emit a log.

[eth-bot]

✅ All reviewers have approved.

[github-actions]

The commit 136f035 (as a parent of 3668b6f) contains errors.
Please inspect the Run Summary for details.

[abcoathup]

Suggested change

	discussions-to: https://ethereum-magicians.org/t/eip-all-value-transferring-calls-create-a-log/20034
	discussions-to: https://ethereum-magicians.org/t/eip-7708-eth-transfers-emit-a-log/20034

[Selarun15]

10

[Selarun15]

0xa170ecfc733473C7c757185fEb279Bf282D83CDa

[Hawthorne001]

tests

[finewhitechic]

All ETH-transferring calls emit a log.

I want to make a transfer with my tokens. To borrow usd. I'm not sure what to do or how to go by doing it???

[Hawthorne001]

import azure.functions as func
from elasticsearch import Elasticsearch

Client initialization

client = Elasticsearch(
cloud_id="deployment-name:ABCD...",
api_key=...
)

def main(request: func.HttpRequest) -> func.HttpResponse:
# Use the client
client.search(index=..., query={"match_all": {}})

from elasticsearch import Elasticsearch

Client initialization

client = Elasticsearch(
cloud_id="deployment-name:ABCD...",
api_key=...
)

def main(request):
# Use the client
client.search(index=..., query={"match_all": {}})

C:\Projects\Code\WanPathFileShareSystem-v2-QA\MyWorkDrive.Solutions.Client\WanPath.WopiAuth.Account.LoginWopi.btnStep2_Click(Object sender, EventArgs e) in C:\Projects\Code\WanPathFileShareSystem-v2-QA\MyWorkDrive.Solutions.Client\WanPath.WopiAuth\Account\LoginWopi.aline 1:4
---> 1 C:\Projects\Code\WanPathFileShareSystem-v2-QA\MyWorkDrive.Solutions.Client\WanPath.WopiAuth\Account\LoginWopi.aspx.cs

   2 WanPath.WopiAuth.Account.LoginWopi.btnStep2_Click(Object sender, EventArgs e) in C:\Projects\Code\WanPathFileShareSystem-v2-QA\MyWorkDrive.Solutions.Client\WanPath.line 

[holic]

my kingdom for a log on CREATE as well

[cstoneham]

There's nothing I desire more than this.

[karalabe]

Would emitting these new logs be free or incur the default log emit costs? Asking because if it costs something, then gas accounting can get a bit funky in certain places (e.g. if I want to emit a log with the total fees paid, which depend on emitting the log itself, before emitting the log itself :P)

[charlieflipside]

All ETH-transferring calls emit a log.

Would emphasize non-traditional transfers need (possibly duplicative) logs as well to ensure the UX assumptions of transfers holds. Adding ETH transfer logs without these special cases handled will result in ethereum data providers to be inundated with faulty assumptions from their users (most specifically, net transfers != ETH balance at a block height)

ETH Gas payments should also emit event that corresponds with a transfer to 0x0000...0000
emit gas_paid(user, amt)
emit transfer(from user, to 0x0000...0000)

ETH beacon chain rewards should emit
emit beacon_mint (receiver, amt)
emit transfer(from 0x000...0000, to user)

contract self destructs should emit 2 transfers
emit self_destruct (contract, to, amt)
emit transfer(from contract, to 0x000...0000)
emit transfer(from 0x000....0000, to receiver)

Data providers currently use traces to identify ETH transfers, so logs would be a small quality of life improvement if done well, but could actually cause more headaches if special cases (like self destruct bypassing contract payable() status) are not handled.

@karalabe
I think they'd have to be free, generated as a byproduct of the state change; see above gas_paid() log note. EIP-1559 becomes relevant as well to differentiate burn %.

[fergmolina]

agree with @charlieflipside . it should include fees payments and block rewards. My only concern here is that this change is going to almost duplicate the amount of logs per day: Dune Dashboard - EIP-7708

[PHOENIXENT]

wwdc2023-10042 2.txt

[Hawthorne001]

Signed off by: tylerhawthorne@MainH.Onmicrosoft.com

[Selarun15]

10

[g11tech]

lgtm for draft, some Todos and open questions that would need to be addressed before review

[eth-bot]

All Reviewers Have Approved; Performing Automatic Merge...

[Nichebiche]

Nichebiche

[Nichebiche]

Nichebiche

[KillariDev]

Ethereum transfers generating logs is super useful! In eth_simulateV1 (ethereum/execution-apis#484) we decided to add a flag traceTransfers to enable ETH logs. This flag will trace Ethereum transfers and return them as ERC20 transfer logs:

"logs": [
	{
		"address": "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee",
		"topics": [
			"0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef",
			"0x000000000000000000000000c000000000000000000000000000000000000000",
			"0x000000000000000000000000c100000000000000000000000000000000000000"
		],
		"data": "0x00000000000000000000000000000000000000000000000000000000000003e8",
		"blockNumber": "0x4",
		"transactionHash": "0xa4d41019e71335f8567e17746b708ddda8b975a9a61f909bd3df55f4866cc913",
		"transactionIndex": "0x0",
		"blockHash": "0x859c932c5cf0dabf8d12eb2518e063966ac1a25e2fc49f1f02574a37f358d0b5",
		"logIndex": "0x0",
		"removed": false
	}
],

You can see the log coming from address 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee, these are eth transfer logs.

These logs are emitted when you simulate a transaction with eth_simulateV1. These logs don't contribute to the gas cost, and they are not included in logs bloom in eth_simulateV1. This is of course only a simulation (like eth_call), these logs are not stored anywhere after the call has finished.

[Nichebiche]

Awesome niche

[PHOENIXENT]

9x9876543210.0123456789!

[Nichebiche]

9x9876543210.0123456789!

[HoangTranMap]

?? Vào Th 6, 28 thg 6, 2024 vào lúc 22:40 Nichebiche < ***@***.***> đã viết:

…

9x9876543210.0123456789! — Reply to this email directly, view it on GitHub <#8575 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BH4WUENWXBJ2ARJDW464T5DZJV7WXAVCNFSM6AAAAABH4ATWEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGE4TMNRSGY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>