Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: EVM Transaction Bundles #8684
Add EIP: EVM Transaction Bundles #8684
Changes from 7 commits
dc6bf95
f4c7164
515eeb1
56818da
cd3c9e3
52c463e
c8bb2b3
aa6065c
6954e77
8b32a00
424af9e
cbc3357
89f5411
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only include the actual gas formula in the specification section. The reasoning behind it should live in the rationale section. Helps to keep the specification as small and readable as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean I should have a code block instead of a verbal description? The words here are describing different parts of the gas costing logic and aren't justifications for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A code block would definitely be fine, but it isn't necessary. I think I just misinterpreted the way you wrote this, honestly.
Instead of writing it as "it must have enough gas to cover...", I'd recommend wording it like:
Introducing the formula with "must have enough gas to cover" just doesn't sound precise enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it! Let me know if you think it still needs work, happy to refactor again.