-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-7702: Do not allow authorization nonce equal to 2**64 - 1 #8905
Conversation
File
|
Is this true? I feel like add bounds outside of basic type widths might add more complexity since it isn't natively part of decoding (e.g. value too big for type!). |
I guess you're right, it's probably the same number of checks, so either extra check at transaction validity, or one at processing authorizations. I don't mind it either way. |
I changed it now to be checked at authorization list processing. |
LGTM. Needs a rebase - I just did in in #8938. Closing |
It is important to not allow
authorization.nonce == 2**64 - 1
, because in this case incrementing authority nonce will result in nonce overflowing 64 bit, which is not allowed since EIP-2681Alternative to adding this to the transaction validity rules could be additional check during delegation setting, but it is simpler this way (fewer checks) and more aligned with existing transaction types validity.It is checked at authorization list processing now.