Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7742: update the required EL headers and the gas fee mechanism #9047

Closed

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Nov 22, 2024

as discussed in the devcon meeting of core devs, it was discussed to attempt a pass a simple effective solution to handle the fee mechanism as we scale target blob counts :

This PR will make sure that when we update the target, previously accumulated excess gas is already correctly scaled to a normalized target so the fees don't drop out when we scale the excess gas update fraction to keep up with the increasing target.

…nism

cleanup

cleanup

cleanup

cleanup

cleanup

fixes

cleanup fee fn

cleanup fee fn

cleanup fee fn

cleanup

some more cleanup

some more cleanup

some more cleanup

track max

apply feedback for excess blob gas on parent gas usage params as in 4844

resolve typo

better variable naming

cleanup text

bring get base fee to eip 4844 definition level as well w.r.t. header arg

apply feedback

clarification

simplify the entire proposal

cleanup

cleanup

apply feedback

language cleanup

restore previous langauge

further cleanup

Update EIPS/eip-7742.md

Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>

apply feedback

rename to blobs per block
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Nov 22, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 22, 2024

File EIPS/eip-7742.md

Requires 1 more reviewers from @ralexstokes

@eth-bot eth-bot added the a-review Waiting on author to review label Nov 22, 2024
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
g11tech and others added 2 commits November 26, 2024 16:05
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
g11tech and others added 9 commits November 27, 2024 01:35
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
EIPS/eip-7742.md Outdated Show resolved Hide resolved
EIPS/eip-7742.md Outdated Show resolved Hide resolved
g11tech and others added 3 commits November 27, 2024 16:28
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@petertdavies
Copy link
Contributor

petertdavies commented Nov 28, 2024

I think the problem with this EIP is that it splits the blob fee pricing between the EL and the CL. The target_blobs_per_block is set on the CL, but the update fraction is set on the EL. In practice the two values are tightly linked in practice.

I think it would make the most sense for the CL to tell the EL `blob_base_fee` and `max_blobs_per_block` and do all the math on the CL. That way the CL can change blobonomics as it sees fit without affecting the EL.

EDIT: Oops, got confused between the live version on eips.ethereum.org and this PR. Still think it would make more sense to do the math on the EL, but not a big deal.

@ralexstokes
Copy link
Member

Decided on ACDC #146 to table this until Fusaka.

Can likely close this PR.

@g11tech
Copy link
Contributor Author

g11tech commented Dec 1, 2024

closing in favor of a combined full proposal here: #9062

@g11tech g11tech closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants