-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERC-820 Pseudo-introspection using a registry contract. #906
Conversation
Notes:
I can contribute a PR if you consider these issues valid. |
@fulldecent , just updated the EIP-820. With all the typos, links, and a better explanation of Nick's deployment method. Regarding the other 2 issues, I have 2 questions: |
For magic, perhaps you can use:
It is an arbitrary choice. But someone reviewing our ERC-721 said that we should reuse ERC-165 style naming because we already have a way to turn a function into a Second item 2 Looks good to me! |
Last item: EIP-X format is to use email addresses in the byline at the top. |
@fulldecent In the current implementation, the Magic number is a full word (bytes32) and not a bytes4. The porpoise of this magic number has nothing to do with EIP165. It makes no sense for me to follow that pattern. Making it so similar may bring to confusion. |
No worries. Thanks for the discussion. |
EIPS/eip-820.md
Outdated
|
||
### The smart contract | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use Solidity syntax highlighting here by using
```solidity
This is a courtesy notice to let you know that the format for EIPs has been modified slightly. If you want your draft merged, you will need to make some small changes to how your EIP is formatted:
If your PR is editing an existing EIP rather than creating a new one, this has already been done for you, and you need only rebase your PR. In addition, a continuous build has been setup, which will check your PR against the rules for EIP formatting automatically once you update your PR. This build ensures all required headers are present, as well as performing a number of other checks. Please rebase your PR against the latest master, and edit your PR to use the above format for frontmatter. For convenience, here's a sample header you can copy and adapt:
|
Please advise if you'd like this merged as a draft in its current state. |
* ERC-820 Pseudo-introspection using a registry contract. * Typos, links, and better explanation of Nicks deployment method * Formating fix * Email address * solidity syntax highlight * Adapt to new template for EIPs * Discussions link added * Fix link in discussion-to * Type fixed
This is the PR discussed in #820
Currently, there is no open issues/conflicts in this standard proposal.