-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Advertisement Tracking Interface #165
Conversation
✅ All reviewers have approved. |
The commit 2baeb4e (as a parent of 21cb2e2) contains errors. |
ac42ab3
to
f4a122c
Compare
any update on this? apprecate it~ |
Hi all, @abcoathup @axic @g11tech @Pandapip1 @SamWilsn @xinbenlv , we need review here, thanks~ |
Confused here? what would be the next step? thx:) |
8ec77d0
to
1a2844b
Compare
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
We may need a reviewer here. that would be awesome |
Could you please explain the purpose of the parameters |
The core of proposal would like to offer good tracking mechanism for advertisement purpose, the Tracking mechanism would act like ads sdk in web2/mobile. Project call |
There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good enough for a draft, but I'd still like to see some more detail on how the off-chain components are supposed to work. Your rationale is also a bit light.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: