Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-2135: fix some typos #304

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

rustrover
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Signed-off-by: rustrover <seekseat@126.com>
@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Mar 9, 2024

File ERCS/erc-2135.md

Requires 1 more reviewers from @xinbenlv
Requires 1 more reviewers from @axic, @gcolvin, @lightclient

File ERCS/erc-5252.md

Requires 1 more reviewers from @hskang9, @smuxx

File ERCS/erc-5023.md

Requires 1 more reviewers from @axic, @gcolvin, @lightclient

File ERCS/erc-6105.md

Requires 1 more reviewers from @axic, @gcolvin, @lightclient

@eip-review-bot eip-review-bot changed the title fix some typos Update ERC-2135: fix some typos Mar 9, 2024
Copy link

@h4l h4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ERCS/erc-6120.md is fine.

Copy link

@yaruno yaruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erc-5023 look ok

@aaronisme
Copy link

erc-4527 looks fine

@SamWilsn SamWilsn merged commit 20942ae into ethereum:master May 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants