Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-3643: Move to Last Call #44

Merged
merged 9 commits into from
Nov 14, 2023
Merged

Conversation

Joachim-Lebrun
Copy link
Contributor

copy of ethereum/EIPs#7871

Move the ERC-3643 to Last Call status after 3 month of call for reviews from the community and successful review sessions with the erc3643 association, where we passed in review with all the members of the association the whole description of the EIP and got approval from all to move forward to final status

@Pandapip1
Copy link
Member

@eth-bot rerun

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 27, 2023

✅ All reviewers have approved.

Nakasar and others added 2 commits November 2, 2023 11:30
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
@Joachim-Lebrun Joachim-Lebrun mentioned this pull request Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

The commit c5c5ab2 (as a parent of a91c221) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Nov 6, 2023
@Joachim-Lebrun
Copy link
Contributor Author

@SamWilsn i added a sub section in the rationale to address your concerns as discussed on the Ethereum Magicians forum I hope this makes everything more clear

@eip-review-bot eip-review-bot enabled auto-merge (squash) November 14, 2023 15:52
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit f74ee68 into ethereum:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants