Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7015: Move to Review #503

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Update ERC-7015: Move to Review #503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5add475
move to review
strollinghome Jun 21, 2024
cb76627
Update erc-7015.md
strollinghome Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ERCS/erc-7015.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
eip: 7015
title: NFT Creator Attribution
description: Extending NFTs with cryptographically secured creator attribution.
author: Carlos Flores (@strollinghome)
author: indreams (@strollinghome)
discussions-to: https://ethereum-magicians.org/t/eip-authorship-attribution-for-erc721/14244
status: Draft
status: Review
type: Standards Track
category: ERC
created: 2023-05-11
Expand All @@ -29,7 +29,7 @@ This EIP takes advantage of the fact that contract addresses can be precomputed

**Signing Mechanism**

Creator consent is given by signing an [EIP-712](./eip-712.md) compatible message; all signatures compliant with this EIP MUST include all fields defined. The struct signed can be any arbitrary data that defines how to create the token; it must hashed in an EIP-712 compatible format with a proper EIP-712 domain.
Creator consent is given by signing an [EIP-712](./eip-712.md) compatible message; all signatures compliant with this EIP MUST include all fields defined. The struct signed can be any arbitrary data that defines how to create the token; it must hashed in an EIP-712 compatible format with a proper EIP-712 domain.

The following shows some examples of structs that could be encoded into `structHash` (defined below):

Expand All @@ -48,7 +48,7 @@ struct TokenCreation {
Creator attribution is given through a signature verification that MUST be verified by the NFT contract being deployed and an event that MUST be emitted by the NFT contract during the deployment transaction. The event includes all the necessary fields for reconstructing the signed digest and validating the signature to ensure it matches the specified creator. The event name is `CreatorAttribution` and includes the following fields:

- `structHash`: hashed information for deploying the NFT contract (e.g. name, symbol, admins etc). This corresponds to the value `hashStruct` as defined in the [EIP-712 definition of hashStruct](./eip-712.md#definition-of-hashstruct) standard.
- `domainName`: the domain name of the contract verifying the singature (for EIP-712 signature validation).
- `domainName`: the domain name of the contract verifying the singature (for EIP-712 signature validation).
- `version`: the version of the contract verifying the signature (for EIP-712 signature validation)
- `creator`: the creator's account
- `signature`: the creator’s signature
Expand All @@ -57,11 +57,11 @@ The event is defined as follows:

```solidity
event CreatorAttribution(
bytes32 structHash,
string domainName,
string version,
bytes32 structHash,
string domainName,
string version,
address creator,
bytes signature
bytes signature
);
```

Expand Down
Loading