Add ERC: Decentralized Identity Verification (DID) #517
Conversation
|
✅ All reviewers have approved. |
xinbenlv
changed the title
eip-review-bot
changed the title
There was a problem hiding this comment.
Aside from the eipw errors, this seems fine. My only concern is that it doesn't provide enough detail on who would want to implement it, and how it's supposed to be used.
How is verifyIdentity supposed to be used? How does the Identity struct get stored in the contract?
Some of that might be covered in your reference implementation, but you need to make sure your standard is implementable with only the Specification section. The Reference Implementation is just an aide to help with understanding.
ERCS/erc-7734.md
Outdated
| --- | ||
| eip: 7734 | ||
| title: Decentralized Identity Verification (DID) | ||
| description: A standard for decentralized identity verification on the Ethereum blockchain. |
There was a problem hiding this comment.
You don't need to mention Ethereum in the title or description. We assume all ERCs are Ethereum related.
ERCS/erc-7734.md
Outdated
|
|
||
| ## Motivation | ||
|
|
||
| Centralized identity verification methods are often cumbersome, prone to data breaches, and do not give users control over their identity data. A decentralized identity verification standard will allow users to maintain control over their identity information while ensuring security and privacy. |
There was a problem hiding this comment.
You should include a bit more detail that differentiates this proposal from others that may be similar. There are a few that are DID-related, if I remember correctly.
There was a problem hiding this comment.
@SamWilsn Updated the code, please check.
eip-review-bot
changed the title
|
The commit 5999900 (as a parent of 4499ff4) contains errors. |
Head branch was pushed to by a user without write access
64anushka
dismissed stale reviews from eip-review-bot and SamWilsn
via
ac1e8fb
|
@SamWilsn please review it, by mistake I changed draft to review, may be because of that the merging has got stopped. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: