-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-6734: Move to Review #601
Update ERC-6734: Move to Review #601
Conversation
@SamWilsn I thought the relative link issue for CVEs had been resolved?! |
That's probably my fault. I'll make sure the linter rules are updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit I can't comment on directly (and please fix before moving into Last Call): you mention "draft standard" when talking about an EIP. That won't make sense when that EIP moves into Final. EIPs should be written as if they were already Final.
EIP-3220 is Stagnant. You'll need to either remove links to it, or help push it to Review.
Removed mention of EIP-3220
Removed mention of EIP-3220 |
…ecanbeonlyone1969
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3220 is still in your requires
field. You'll either need to remove it or open a pull request moving 3220 to Review.
Updated |
The commit 15c10e7 (as a parent of de53def) contains errors. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: